| 4 Apr 2022 |
 @janne.hess:helsinki-systems.de | also fyi: https://github.com/NixOS/nixpkgs/pull/165892 | 10:41:56 |
| @janne.hess:helsinki-systems.de | we might want to adapt that | 10:42:01 |
 @elvishjerricco:matrix.org | huh, well that's interesting | 10:43:08 |
 Arian | Definitely | 11:29:23 |
| @janne.hess:helsinki-systems.de | Good news: | 15:41:21 |
| @janne.hess:helsinki-systems.de | 
Download image.png | 15:41:23 |
 bobvanderlinden | 😅 the LUKS part is already in my branch. The lvm2 part is still lacking. | 15:48:02 |
| @janne.hess:helsinki-systems.de | bobvanderlinden: can you send me the branch? | 15:52:18 |
| @janne.hess:helsinki-systems.de | I also found some other things that we should probably fix | 15:52:33 |
| bobvanderlinden | https://github.com/bobvanderlinden/nixpkgs/tree/pr-systemd-initrd-luks-lvm | 16:07:05 |
| bobvanderlinden | Luks:
https://github.com/bobvanderlinden/nixpkgs/blob/pr-systemd-initrd-luks-lvm/nixos/modules/system/boot/initrd-systemd-luks.nix | 16:07:47 |
| bobvanderlinden | Udev and initial work on lvm2 are in the same directory under similar path | 16:09:11 |
| @janne.hess:helsinki-systems.de | ah great, I did it in the current luksroot module which is a bit more messy than your approach | 16:09:23 |
| bobvanderlinden | Yea we do need to find a nice way to structure the modules with all the different combinations. It would be nice if there was a initrd-systemd directory that can include them all | 16:11:02 |
| bobvanderlinden | But didn't want to conflict with other work 😅 | 16:11:28 |
| bobvanderlinden | For lvm2 I think using the ueventd variant as the package could already be a good step in the right direction. | 16:13:25 |
| @janne.hess:helsinki-systems.de | This will probably break your cryptsetup again :/ https://github.com/NixOS/nixpkgs/pull/167167 | 16:20:41 |
| @janne.hess:helsinki-systems.de | but I think it might be one of the last breakages I create 🤞 | 16:21:16 |
| bobvanderlinden | Haha I liked that pr. It does make things a bit more insightful from nix code. Though I am still interested in gathering the files using /nix/store references, as that would in theory avoid problems like not including a binary by accident or including too much without it being used. Theory is different from practice though, so it probably needs tweaking nonetheless. | 16:30:21 |
| @janne.hess:helsinki-systems.de | roberth suggested a second option that deeply traces the closure dependencies with exportReferencesGraph or something like this | 16:31:17 |
| bobvanderlinden | Ah that would satisfy my need as well 👍 good solution | 16:36:17 |
| @janne.hess:helsinki-systems.de | yeah I think doing that by default for all store paths would bloat the initrd too much | 16:36:43 |
| Arian | Janne Heß: we can probably pick flokli 's brain about the init=/systemConfig= dillemma | 16:40:22 |
| @janne.hess:helsinki-systems.de | 🧠⛏️ | 16:41:00 |
 flokli | Stop picking my brain | 16:51:46 |
| flokli | 
Download tenor_gif2894795343590525608.gif | 16:52:15 |
| @janne.hess:helsinki-systems.de | Is this enough context to understand what our discussion is? https://github.com/NixOS/nixpkgs/pull/167168#discussion_r841894434 | 17:15:56 |
| bobvanderlinden | I focused on the luks changes and updated those to the new changes on master (objects -> contents). It includes udev and luks. Draft PR: https://github.com/NixOS/nixpkgs/pull/167231 | 20:35:09 |
| @janne.hess:helsinki-systems.de | In reply to @bobvanderlinden_:matrix.org
I focused on the luks changes and updated those to the new changes on master (objects -> contents). It includes udev and luks. Draft PR: https://github.com/NixOS/nixpkgs/pull/167231 would you be okay with me potentially taking your code tomorrow and reworking it into a larger PR? | 20:55:29 |
| bobvanderlinden | yea totally. Not sure if a larger PR will be merged sooner, but it's totally fine to reuse the code/commits. | 20:56:29 |
