Stage 1 systemd | 73 Members | |
| systemd in NixOs's stage 1, replacing the current bash tooling https://github.com/NixOS/nixpkgs/projects/51 | 23 Servers |
| Sender | Message | Time |
|---|---|---|
| 18 Apr 2023 | ||
There is no use case where systemd-repart alters only non-root disks and cannot be run in stage 2 and ordered before whatever services depend on it. | 16:44:20 | |
And there's absolutely no point in running it in stage 1 if running it requires initrd-fs.target to be reached | 16:46:27 | |
(the nixos module just requires sysroot.mount to be reached but if this is the design we're going with it really should wait for /sysroot/nix/store, and the simplest way is initrd-fs.target) | 16:47:44 | |
| The docs say this is the default: "By default when invoked on the regular system this defaults to the host's root file system /. If invoked from the initrd this defaults to /sysroot/, so that the tool operates on the configuration and machine ID stored in the root file system later transitioned into itself.". I tried to stay as close as possible to the default. systemd-repart actually does not only look into sysusr. It also looks for configs in /sysroot/etc. E.g. see the conditions for the service:
If I understand it correctly, your point is that the nix store might not be on sysroot but instead mounted later (alongside the other partitions marked with I also agree that /sysusr/ is the preferred/ideal way to store the config files in the systemd world. However, I don't see a way to imitate that in NixOS. On the top of my head I can think of at least one solid use case where systemd-repart has to run in the initrd. Imagine you have disk images that only contain the Nix Store on the root fs without even space in the root fs to accomodate the rest of the / subtree created during activation. Repart can then make the space in the root fs after sysroot.mount (or even initrd-fs.target) but before activation. I don't really love baking configuration (i.e. the repart configs) into the initrd if it can be avoided. And again, I think the current module is closer to how systemd-repart operates by default than the alternative of baking the configs into the initrd. But maybe we can give users the option in the module. | 21:22:01 | |
| Sorry for the long ass reply. This was a good exercise to think it all through again :) | 21:22:38 | |
| * The docs say this is the default: "By default when invoked on the regular system this defaults to the host's root file system /. If invoked from the initrd this defaults to /sysroot/, so that the tool operates on the configuration and machine ID stored in the root file system later transitioned into itself.". I tried to stay as close as possible to the default. systemd-repart actually does not only look into sysusr. It also looks for configs in /sysroot/etc. E.g. see the conditions for the service:
If I understand it correctly, your point is that the nix store might not be on sysroot but instead mounted later (alongside the other partitions marked with I also agree that /sysusr/ is the preferred/ideal way to store the config files in the systemd world. However, I don't see a way to imitate that in NixOS. On the top of my head I can think of at least one solid use case where systemd-repart has to run in the initrd. Imagine you have disk images that only contain the Nix Store on the root fs without even space in the root fs to accomodate the rest of the / subtree created during activation. Repart can then make the space in the root fs after sysroot.mount (or even I don't really love baking configuration (i.e. the repart configs) into the initrd if it can be avoided. And again, I think the current module is closer to how systemd-repart operates by default than the alternative of baking the configs into the initrd. But maybe we can give users the option in the module. | 21:25:01 | |
I think you're leaning heavily on this line as the only indication of how the docs want it to work in initrd. But I still think it's a misinterpretation. By defaulting to | 21:39:12 | |
| I'm made more confident about this given a comment I received from poettering suggesting that root fs formatting is the job of repart | 21:40:46 | |
Partitions can often be resized online. e.g. Look at how | 21:45:07 | |
(in fact that's how fileSystems.<name>.autoResize works with systemd initrd enabled) | 21:46:40 | |
I maintain that there is no excuse for mounting the root FS before running systemd-repart in initrd. | 21:47:46 | |
| ah wait I misunderstood the example | 21:49:29 | |
| hmm | 21:49:51 | |
| well that use case would still be taken care of by running systemd-repart before mounting /sysroot | 21:50:39 | |
In reply to @elvishjerricco:matrix.orgWell there is also this: "On systems where usr= is not used this target is ordered after sysroot.mount and thus mostly equivalent to initrd-root-fs.target." https://www.freedesktop.org/software/systemd/man/systemd.special.html#initrd-usr-fs.target which means the default Before= in the systemd-repart.service is essentially equivalet to Before=initrd-root-fs.target and then there is also this comment in the code: https://github.com/systemd/systemd/blob/main/src/partition/repart.c#L6109 | 21:51:10 | |
| So I fully agree that it would be awesome to even be able to create the root fs with systemd-repat (which means it has to run before sysroot.mount) but we don't have a /sysuser. So the only thing we can really do is bake the configs into the initrd, which I don't love but I'd be willing to offer it as an option. My argument is not that the current solution is the end-all be-all but that it has a purpose and we should not get rid of it, but we might add on to it. | 21:53:10 | |
| * So I fully agree that it would be awesome to even be able to create the root fs with systemd-repart (which means it has to run before sysroot.mount) but we don't have a /sysuser. So the only thing we can really do is bake the configs into the initrd, which I don't love but I'd be willing to offer it as an option. My argument is not that the current solution is the end-all be-all but that it has a purpose and we should not get rid of it, but we might add on to it. | 21:53:19 | |
As far as I can tell, any usecase that requires systemd-repart being run in initrd is a use case where it's perfectly acceptable to put the config files in the initrd | 21:55:37 | |
| when the purpose is to mess with the root fs before mounting, initrd is the correct place | 21:55:57 | |
| and if the purpose has nothing to do with the root fs, it almost certainly can/should be done in stage 2 | 21:57:19 | |
| Even if I agree with that (and I'm not too far away) then the fact still remains that systemd-repart thinks its sensible to operate also on /sysroot. I think we should give the users the option to use the tool as close to the default as possible (even if there are compromises because NixOS works differently than other distros). All the users that think repart should exclusively run in stage 2 can still configure it that way. The module already offers this flexibility. | 22:01:35 | |
| The docs don't say repart works on a mounted /sysroot by default. repart is designed to work on unmounted devices. | 22:03:22 | |
When they say it defaults to /sysroot, they mean it works on the device that will be eventually mounted as /sysroot | 22:04:05 | |
| But it finds config files in the sysroot. How can it find config files in the sysroot if it is not mounted? | 22:04:41 | |
| that's a good question :P I'm not sure why they have code that checks that unless it's just for robustness | 22:05:21 | |
| but given that poettering himself has told me that repart is meant to be used for partitioning the root disk, I'm heavily inclined to believe that's what it's for in initrd | 22:06:13 | |
| I'm like 90% certain that it works on a mounted sysroot but maybe I'm also losing my mind. | 22:06:37 | |
| * but given that poettering himself has told me that repart is meant to be used for partitioning/formatting the root disk, I'm heavily inclined to believe that's what it's for in initrd | 22:06:40 | |
In reply to @elvishjerricco:matrix.orgIt definetely is. There is no contradiction. It can just do more than that | 22:06:58 | |
| I mean it very well might, even if that's just additional functionality | 22:07:06 | |