In reply to @elvishjerricco:matrix.org
That's not good

In reply to @lily:lily.flowers
Should we try to strip that out or just make our own initrd os-release attrset with less info to begin with?

  addSections = pkgs.writeShellScriptBin "add-sections" ''
    set -euo pipefail
    stub="$1"
    image="$2"

    stub_line=$(${pkgs.binutils}/bin/objdump -h "$stub" | tail -2 | head -1)
    stub_size=0x$(echo "$stub_line" | awk '{print $3}')
    stub_offs=0x$(echo "$stub_line" | awk '{print $4}')
    next_offs=$((stub_size + stub_offs))
    args=()

    while read sectionName contentsFile; do
      contentsFile="$(readlink -f "$contentsFile")"
      args+=(--add-section "$sectionName"="$contentsFile")
      args+=(--change-section-vma "$sectionName"=$(printf 0x%x $next_offs))
      next_offs=$((next_offs + $(stat -c%s "$contentsFile")))
    done

    set -x
    exec ${pkgs.binutils}/bin/objcopy "''${args[@]}" "$stub" "$image"
  '';
  stub = pkgs.runCommand "stub" {nativeBuildInputs = [addSections];} ''
    mkdir $out
    add-sections ${nixosConfig}/systemd/lib/systemd/boot/efi/linuxx64.efi.stub $out/foo-unsigned.efi <<EOF
      .osrel ${osRelease}
      .linux ${nixosConfig}/kernel
      .initrd ${nixosConfig}/initrd${lib.optionalString kernelBoot "\n.cmdline ${cmdline}"}
    EOF
  '';

  addSections = pkgs.writeShellScriptBin "add-sections" ''
    set -euo pipefail
    stub="$1"
    image="$2"

    stub_line=$(${pkgs.binutils}/bin/objdump -h "$stub" | tail -2 | head -1)
    stub_size=0x$(echo "$stub_line" | awk '{print $3}')
    stub_offs=0x$(echo "$stub_line" | awk '{print $4}')
    next_offs=$((stub_size + stub_offs))
    args=()

    while read sectionName contentsFile; do
      contentsFile="$(readlink -f "$contentsFile")"
      args+=(--add-section "$sectionName"="$contentsFile")
      args+=(--change-section-vma "$sectionName"=$(printf 0x%x $next_offs))
      next_offs=$((next_offs + $(stat -c%s "$contentsFile")))
    done

    set -x
    exec ${pkgs.binutils}/bin/objcopy "''${args[@]}" "$stub" "$image"
  '';
  stub = pkgs.runCommand "stub" {nativeBuildInputs = [addSections];} ''
    mkdir $out
    add-sections ${nixosConfig}/systemd/lib/systemd/boot/efi/linuxx64.efi.stub $out/foo-unsigned.efi <<EOF
      .osrel ${osRelease}
      .linux ${nixosConfig}/kernel
      .initrd ${nixosConfig}/initrd
    EOF
  '';

Lily Foster: Possibly? For some reason there was an issue in the networkd PR when that was enabled: https://github.com/NixOS/nixpkgs/pull/169116/files#diff-68fef76b66b99ee77baba62969a434c1f912c2fcf8765bfc884b7aa5b0e70d35R71-R72

It was just a unit ordering issue, so it had nothing to do with its lack of implementation. But I can't remember what it was, considering it's been 9 months since I wrote that comment :P

In reply to @elvishjerricco:matrix.org
It's possible that issue only existed back when I was trying to reuse the openssh module verbatim in stage 1, rather than doing the dead simple thing like the PR does now

In reply to @elvishjerricco:matrix.org
Lily Foster: Feel free. Though fwiw I kinda doubt tmpfiles would be useful for us in stage 1.