| 28 Jan 2023 |
 @elvishjerricco:matrix.org | My fsck PR does fix the ordering for file systems that systemd generates fsck units for, but only by happenstance. systemd-hibernate-resume@.service comes Before=local-fs-pre.target, but systemd is dumb and doesn't add After=local-fs-pre.target to initrd file systems. However, it does add it to fsck units | 22:42:04 |
| @elvishjerricco:matrix.org | which is the only reason it works right upstream | 22:42:11 |
 @lily:lily.flowers | In reply to @elvishjerricco:matrix.org
which is the only reason it works right upstream Oh dear.... So things are only working by accident upstream right now? | 22:42:49 |
| @elvishjerricco:matrix.org | essentially | 22:43:05 |
| @elvishjerricco:matrix.org | I have a patch for that | 22:43:11 |
| @lily:lily.flowers | That's horrifying | 22:43:12 |
| @elvishjerricco:matrix.org | I have like three or four systemd patches that I need to properly evaluate and open a PR with | 22:43:36 |
| @elvishjerricco:matrix.org | I need to go eat dinner before I try fixing the ordering thing | 22:44:46 |
| @lily:lily.flowers | In reply to @elvishjerricco:matrix.org
I need to go eat dinner before I try fixing the ordering thing Okay, I may take a closer look tomorrow too, depending on what you find out (not sure I'll have time/energy/motivation to debug deep linux arcana tonight) | 22:46:26 |
| @elvishjerricco:matrix.org | Lily Foster: Yea, adding proper ordering fixes it :/ | 23:12:24 |
| @elvishjerricco:matrix.org | ooohhh I see why it's an issue with swap files and not block devices | 23:27:15 |
| @elvishjerricco:matrix.org | systemd-hibernate-resume@.service and sysroot.mount will compete for access to the same block device if swap is on a swap file | 23:27:55 |
| @elvishjerricco:matrix.org | if swap is on another device you'll just get the silent scaries :P | 23:28:14 |
| @elvishjerricco:matrix.org | let me see if the same happens with ext4 | 23:28:27 |
| @lily:lily.flowers | In reply to @elvishjerricco:matrix.org
systemd-hibernate-resume@.service and sysroot.mount will compete for access to the same block device if swap is on a swap file Oh how nice... | 23:29:40 |
| @lily:lily.flowers | I saw there was a systemd v253 rc with your changes with it. Once that's released and in nixpkgs, that would unblock your stage1 fsck PR, right? | 23:30:18 |
| @elvishjerricco:matrix.org | Yep, same exact thing with a swap file on ext4 | 23:30:33 |
| @elvishjerricco:matrix.org | Lily Foster: Yea, that would unblock the fsck pr | 23:30:43 |
| @elvishjerricco:matrix.org | though I don't think that would help btrfs | 23:31:04 |
| @elvishjerricco:matrix.org | since I think that's one of the file systems we don't fsck | 23:31:10 |
| @lily:lily.flowers | Oh yeah good point | 23:31:18 |
| @lily:lily.flowers | (also btrfs recommends to not try anything resembling fsck on it) | 23:31:27 |
| @elvishjerricco:matrix.org | right | 23:31:50 |
| @elvishjerricco:matrix.org | so we need... | 23:32:10 |
| @elvishjerricco:matrix.org | This: https://github.com/NixOS/nixpkgs/commit/d97a2f4d5eecfe74b619179144b575c8b9f7cd19 | 23:32:28 |
| @lily:lily.flowers | How is this not broken in other OS's using like dracut and such? | 23:32:49 |
| @elvishjerricco:matrix.org | dracut may have its own special sauce to fix it | 23:33:13 |
| @elvishjerricco:matrix.org | I don't know | 23:33:17 |
| @elvishjerricco:matrix.org | I try not to look at it unless I have to :P | 23:33:22 |
| @elvishjerricco:matrix.org | or | 23:33:41 |
