22 May 2023 |
Arian | wondering why it works for you in build sandbox and not for me | 18:43:38 |
@nikstur:matrix.org | Mhmm I'll investigate this tomorrow | 18:46:40 |
Arian | ill push my changes one sec. | 18:48:09 |
@nikstur:matrix.org | Ahh it didn't land in 253-stable: https://github.com/systemd/systemd-stable/blob/v253-stable/src/partition/repart.c#L3917 | 18:48:55 |
@nikstur:matrix.org | even if the commit was from a day before they tagged | 18:49:07 |
Arian | https://github.com/arianvp/server-optimised-nixos/blob/157ef33b278b581b92aad8c3200941139d84f96a/flake.nix | 18:50:05 |
Arian | aha! | 18:50:20 |
Arian | that explains | 18:50:22 |
Arian | i'll ask for a backport | 18:50:33 |
@nikstur:matrix.org | That would be nice | 18:50:42 |
@nikstur:matrix.org | But that means they have created the 253-stable branch before they tagged the release in the main repo | 18:51:01 |
Arian | oh that is really strange. | 18:54:15 |
Arian | Sorry false alarm. the commit is not in v253 . My git foo was off | 18:59:24 |
Arian | https://github.com/systemd/systemd-stable/pull/295 | 18:59:34 |
Arian | The answer was "This is really stretching the backport policy. But we can see what the others say" | 18:59:50 |
ElvishJerricco |
This is really stretching the backport policy. But we can see what the others say
Where was this said?
| 19:01:43 |
Arian | To me personally by a systemd dev | 19:02:08 |
Arian | I just noticed nikstur is in the same chat where I asked it lol | 19:03:31 |
@nikstur:matrix.org | But why is it not in v253? | 19:03:37 |
ElvishJerricco | was that in an irc room or something? I'm honestly still not sure where all the systemd communications go on :P | 19:03:37 |
@nikstur:matrix.org | Ahh they do more cherry-picking and delaying than I thought they do | 19:05:15 |
@nikstur:matrix.org | Because the commit was on the 14th Feb and they tagged the release on the 15th | 19:05:42 |
@nikstur:matrix.org | In reply to @arianvp:matrix.org Ill make a PR to add the repart definitions file to config.system.build.repartDefitions so that it can be consumed by image builder I thought about that too. The biggest problem is that you likely want to create different partitions in the disk image than you want systemd-repart to create on the final disk (e.g. create a root, A/B partitions etc.) | 19:13:35 |
Arian | Ah good point | 19:42:26 |
Arian | Yeh maybe i make a new Nixos module option then. OTOH repart just skips partitions that already exist. So might just work | 19:42:49 |
@nikstur:matrix.org | Yes it skips existing ones but you'd have the opposite problem: you'd create partitions earlier (during disk creation) than you would actually want them (on first boot). | 20:19:35 |
Arian | Separate config it is then :) | 21:53:51 |
@nikstur:matrix.org | Is this something you want to upstream into Nixpkgs? | 21:59:56 |
@nikstur:matrix.org | The image builder? | 22:00:10 |
Arian | Definitely | 22:07:30 |