22 May 2023 |
Arian | idk why it's not being picked up | 18:23:13 |
Arian | urgh and cant reproduce in nix develop . Then it does work. strange | 18:30:17 |
Arian | Seems for some reason systemd'sis_dir_full() returns false for the /build folder in the build sandbox. | 18:34:38 |
@nikstur:matrix.org | I needed this commit to make systemd-repart behave nicely in the build sandbox | 18:38:09 |
@nikstur:matrix.org | Which is after v253 | 18:38:22 |
@nikstur:matrix.org | https://github.com/systemd/systemd/commit/1eb86ddde4f36165a99732b53cc97cef1acc3aa7 | 18:39:11 |
@nikstur:matrix.org | wait... this wasnt after 253 | 18:39:57 |
Arian | it is though no? | 18:41:36 |
Arian | dont see the commit associated with any tags | 18:41:42 |
Arian | No. this is in v253. you're right. Weird | 18:43:09 |
Arian | wondering why it works for you in build sandbox and not for me | 18:43:38 |
@nikstur:matrix.org | Mhmm I'll investigate this tomorrow | 18:46:40 |
Arian | ill push my changes one sec. | 18:48:09 |
@nikstur:matrix.org | Ahh it didn't land in 253-stable: https://github.com/systemd/systemd-stable/blob/v253-stable/src/partition/repart.c#L3917 | 18:48:55 |
@nikstur:matrix.org | even if the commit was from a day before they tagged | 18:49:07 |
Arian | https://github.com/arianvp/server-optimised-nixos/blob/157ef33b278b581b92aad8c3200941139d84f96a/flake.nix | 18:50:05 |
Arian | aha! | 18:50:20 |
Arian | that explains | 18:50:22 |
Arian | i'll ask for a backport | 18:50:33 |
@nikstur:matrix.org | That would be nice | 18:50:42 |
@nikstur:matrix.org | But that means they have created the 253-stable branch before they tagged the release in the main repo | 18:51:01 |
Arian | oh that is really strange. | 18:54:15 |
Arian | Sorry false alarm. the commit is not in v253 . My git foo was off | 18:59:24 |
Arian | https://github.com/systemd/systemd-stable/pull/295 | 18:59:34 |
Arian | The answer was "This is really stretching the backport policy. But we can see what the others say" | 18:59:50 |
@elvishjerricco:matrix.org |
This is really stretching the backport policy. But we can see what the others say
Where was this said?
| 19:01:43 |
Arian | To me personally by a systemd dev | 19:02:08 |
Arian | I just noticed nikstur is in the same chat where I asked it lol | 19:03:31 |
@nikstur:matrix.org | But why is it not in v253? | 19:03:37 |
@elvishjerricco:matrix.org | was that in an irc room or something? I'm honestly still not sure where all the systemd communications go on :P | 19:03:37 |