29 Jun 2023 |
@lily:lily.flowers | Yep scripted stage-1 absolutely does | 20:12:45 |
@lily:lily.flowers | Yeah I guess so | 20:12:52 |
@lily:lily.flowers | Yeah git blame says it was added in the initial sd-initrd commit | 20:13:30 |
@lily:lily.flowers | Gonna make a PR to unhide that then | 20:13:36 |
@lily:lily.flowers | I should probably backport that PR too then, right? | 20:17:14 |
@elvishjerricco:matrix.org | I guess? I tend not to think about stable when working on sd-initrd. Once we remove the "experimental" denotation in the docs, I'll have to change my ways though :P | 20:17:55 |
@lily:lily.flowers | I opened https://github.com/NixOS/nixpkgs/pull/240601, but I actually found a lot more options all over the place left hidden that I'm fixing now. So I'm gonna push those to that PR too and rename it in a minute | 20:25:00 |
@elvishjerricco:matrix.org | interesting... | 20:25:58 |
@elvishjerricco:matrix.org | I thought I had built the options JSON thingy with hidden options included and scanned over them all a while ago | 20:26:15 |
@lily:lily.flowers | Was boot.initrd.systemd.users and stuff specifically supposed to be left hidden ElvishJerricco? | 20:26:19 |
@lily:lily.flowers | In reply to @elvishjerricco:matrix.org I thought I had built the options JSON thingy with hidden options included and scanned over them all a while ago I mean maybe most of these were supposed to stay hidden. I think I've found 5 more | 20:26:32 |
@elvishjerricco:matrix.org | In reply to @lily:lily.flowers Was boot.initrd.systemd.users and stuff specifically supposed to be left hidden ElvishJerricco? I never had an opinion on that... | 20:26:47 |
@elvishjerricco:matrix.org | It's certainly kind of an internal thing | 20:26:54 |
@elvishjerricco:matrix.org | but also feasible that people would need it | 20:26:59 |
@lily:lily.flowers | I'll unhide it then I suppose. It's not like we hide other internal please-do-not-change-unless-you-know-what-you-are-doing options | 20:27:38 |
@elvishjerricco:matrix.org | we actually do though | 20:27:52 |
@lily:lily.flowers | (well mostly ... there are a few. We really don't have a policy on it afaik) | 20:27:53 |
@elvishjerricco:matrix.org | there are plenty of options marked "internal" | 20:27:58 |
@lily:lily.flowers | Yeah, but these are visible = false | 20:28:06 |
@elvishjerricco:matrix.org | Does internal = true also imply "pls no show in manual"? | 20:28:38 |
@lily:lily.flowers | I believe so. Most of those are like module-internal rather than bad-idea-but-you-can-mess-with-it-if-you-want internal | 20:29:01 |
@elvishjerricco:matrix.org | gotcha | 20:29:12 |
@elvishjerricco:matrix.org | alright cool | 20:29:14 |
@lily:lily.flowers | Like you can disable nscd if you really want to, but it's explicitly discouraged in the option | 20:29:30 |
@lily:lily.flowers | The amount I care is not much though, so I'm happy to defer to your judgement | 20:29:38 |
@elvishjerricco:matrix.org | yea I don't have any sort of opinion really | 20:29:57 |
@lily:lily.flowers | Okay so the sd-initrd options left hidden seems to have been:
boot.initrd.systemd.users (and boot.initrd.systemd.users.[user].uid )
boot.initrd.systemd.groups (and boot.initrd.systemd.groups.[group].gid )
boot.initrd.services.udev.packages
boot.initrd.services.udev.binPackages
boot.initrd.systemd.dbus.enable
boot.initrd.services.bcache.enable
boot.initrd.services.swraid.enable
| 20:31:48 |
@lily:lily.flowers | Sound good to remove visible = false ElvishJerricco? I'll push to the PR in a bit | 20:32:07 |
@elvishjerricco:matrix.org | Sure. Also, this reminds me that we really need to fix up the optional disk features PR. Title says swraid but I think we want it to hit all these things that we're making optional | 20:33:32 |
@elvishjerricco:matrix.org | Which is mainly lvm, bcache, and swraid, I think | 20:34:22 |