| 11 Apr 2023 |
 flokli | yes | 08:42:15 |
| flokli | Redacted or Malformed Event | 08:42:20 |
 @elvishjerricco:matrix.org | Likely final call for review on networkd: https://github.com/NixOS/nixpkgs/pull/169116#issuecomment-1503958180 | 19:12:08 |
| @elvishjerricco:matrix.org | Janne Heß, Lily Foster: I'm particularly interested in whether either of you have comments, given your relatively high levels of involvement with systemd stage 1 development. | 19:13:04 |
 @lily:lily.flowers | I'll try to get to it tonight. I've skimmed it before and nothing stuck out as a problem then, but I haven't actually given it a more in-depth review | 19:18:40 |
| 12 Apr 2023 |
 @janne.hess:helsinki-systems.de | Can try if I find the time :/ Don't hesitate to merge without my review in case I never get to it | 07:50:00 |
|  @andi:kack.it changed their display name from andi- to andi-|m. | 10:39:39 |
| @andi:kack.it changed their display name from andi-|m to andi-. | 13:02:49 |
| @elvishjerricco:matrix.org | TIL we have a repart module now... And it doesn't seem right at all to me. It waits for sysroot.mount before running but the only reason you would use this in initrd is to partition/format sysroot. And sysroot.mount isn't even the right thing to wait for; as written it needs to wait for /sysroot/nix/store | 18:35:49 |
| @elvishjerricco:matrix.org | like, if we're going to require the stage 2 fs to be set up, then we should do it in stage 2, not stage 1. And if you're doing it in stage 1, just put the config files in stage 1 | 18:37:07 |
| @elvishjerricco:matrix.org | * like, if we're going to require the stage 2 fs to be set up, then we should do it in stage 2, not stage 1. And if we're doing it in stage 1, just put the config files in stage 1 | 18:37:15 |
 @arianvp:matrix.org | Hmm | 19:03:06 |
| 15 Apr 2023 |
| @elvishjerricco:matrix.org | https://github.com/NixOS/nixpkgs/pull/226237 | 07:41:18 |
| @elvishjerricco:matrix.org | It'd be great to gets docs unhidden for 23.05 | 07:41:33 |
|  Yinfeng changed their profile picture. | 15:05:02 |
| Yinfeng changed their profile picture. | 15:08:57 |
| Yinfeng removed their profile picture. | 15:12:08 |
| Yinfeng set a profile picture. | 15:12:36 |
| 16 Apr 2023 |
| @elvishjerricco:matrix.org | flokli: I think I've addressed all the comments on the networkd PR. Can we hit the merge button sometime soon? | 00:47:23 |
| @elvishjerricco:matrix.org | flokli: If flushBeforeStage2 is a blocker, let's split that out into a separate PR. I'm just confused why its a question now when it's been a part of scripted initrd for a long time. | 16:34:03 |
| @elvishjerricco:matrix.org | * flokli: If flushBeforeStage2 is a blocker, let's split that out into a separate PR. I'm just confused why it's a question now when it's been a part of scripted initrd for a long time. | 16:34:22 |
 @hexa:lossy.network | not sure what is unclear about setting the network down before leaving stage1 | 16:39:03 |
| @hexa:lossy.network | I consider that a mandatory step to not break network settings that stage2 wants to apply | 16:39:36 |
| @elvishjerricco:matrix.org | hexa: the systemd-networkd man page suggests not bringing things down before stage 2 so that everything stays configured all the way through. I think for the typical case, the configuration in stage 2 and stage 1 will be the same, so this seems fine to me? | 16:40:46 |
| @elvishjerricco:matrix.org | i.e. DHCP on interfaces X, Y, Z, and that's about it | 16:41:01 |
| @hexa:lossy.network | what if I try to rename a link in my stage2? | 16:41:11 |
| @elvishjerricco:matrix.org | I would say that's atypical | 16:41:19 |
| @elvishjerricco:matrix.org | and you can set flushBeforeStage2 = true for that :) | 16:41:28 |
| @hexa:lossy.network | basically what you're saying is that people should configure their whole networking in stage1 as opposed to stage2? | 16:42:01 |
| @elvishjerricco:matrix.org | No? | 16:42:15 |
