| 3 Apr 2022 |
| *  colemickens 👀 for a luks pr to test | 23:18:11 |
| 4 Apr 2022 |
 @janne.hess:helsinki-systems.de | ElvishJerricco or bobvanderlinden: didn't one of you try to build the image without calling cpio? Is that still an ongoing effort? | 09:25:44 |
 @elvishjerricco:matrix.org | Janne Heß: How would you make the archive without cpio? Maybe you're thinking of what bobvanderlinden did to avoid copying all the files to a temporary location before writing out with cpio? | 09:27:21 |
| @elvishjerricco:matrix.org | That's something I'd consider valuable but never bothered to add to the PR | 09:27:40 |
| @janne.hess:helsinki-systems.de | I thought you were planning to use some tool that fell out of the kernel source tree… 🤔 | 09:27:48 |
| @elvishjerricco:matrix.org | I do not know of such a tool | 09:28:12 |
| @janne.hess:helsinki-systems.de | maybe I am just mistaken between the hundreds of messages here :D | 09:28:23 |
| @elvishjerricco:matrix.org | Janne Heß: Maybe it was this? https://github.com/NixOS/nixpkgs/pull/120015#issuecomment-1066027673 | 09:55:32 |
| @janne.hess:helsinki-systems.de | ah probably, yes | 09:57:42 |
| @janne.hess:helsinki-systems.de | but we worked around the issue by using the rust tool? | 09:57:51 |
| @elvishjerricco:matrix.org | Janne Heß: Don't think so. The rust tool still copies stuff around. | 10:21:16 |
| @elvishjerricco:matrix.org | bobvanderlindenmade a commit a while ago that avoided the copying | 10:22:40 |
 bobvanderlinden | Indeed. It was in a fork of your old branch. Outputs paths on stdout and pipes that to cpio.
It also included looking for other /nix/store paths in non-elf files, but that part was considered unneeded and may be dropped.
I can take a look creating a PR for the change tonight (20.00 cest). | 10:35:05 |
| @elvishjerricco:matrix.org | bobvanderlinden: Yea I'd very much like a PR for the part that avoids copying, but the part that searches for other /nix/store paths was probably a problem for a different PR | 10:37:44 |
| bobvanderlinden | Agreed 👍 different discussion | 10:38:23 |
| bobvanderlinden | It did still use cpio though. Might be cool to implement a basic cpio output in the rust tool as well, but that's also something for later I guess | 10:39:35 |
| @elvishjerricco:matrix.org | I have no problem with using cpio. Avoiding the copying is valuable because it produces less wear and tear on the underlying storage | 10:41:05 |
| @elvishjerricco:matrix.org | I know it's minimal, but for stuff like Hydra builders that will make a bazillion of these per day, it can make a difference | 10:41:44 |
| @janne.hess:helsinki-systems.de | also fyi: https://github.com/NixOS/nixpkgs/pull/165892 | 10:41:56 |
| @janne.hess:helsinki-systems.de | we might want to adapt that | 10:42:01 |
| @elvishjerricco:matrix.org | huh, well that's interesting | 10:43:08 |
 @arianvp:matrix.org | Definitely | 11:29:23 |
| @janne.hess:helsinki-systems.de | Good news: | 15:41:21 |
| @janne.hess:helsinki-systems.de | 
Download image.png | 15:41:23 |
| bobvanderlinden | 😅 the LUKS part is already in my branch. The lvm2 part is still lacking. | 15:48:02 |
| @janne.hess:helsinki-systems.de | bobvanderlinden: can you send me the branch? | 15:52:18 |
| @janne.hess:helsinki-systems.de | I also found some other things that we should probably fix | 15:52:33 |
| bobvanderlinden | https://github.com/bobvanderlinden/nixpkgs/tree/pr-systemd-initrd-luks-lvm | 16:07:05 |
| bobvanderlinden | Luks:
https://github.com/bobvanderlinden/nixpkgs/blob/pr-systemd-initrd-luks-lvm/nixos/modules/system/boot/initrd-systemd-luks.nix | 16:07:47 |
| bobvanderlinden | Udev and initial work on lvm2 are in the same directory under similar path | 16:09:11 |
