| 24 Mar 2022 |
flokli | lol | 20:39:29 |
@janne.hess:helsinki-systems.de | systemdPath="$(readlink -f "/sysroot$closure/systemd")/lib/systemd/systemd"
mkdir -p "$(dirname "$systemdPath")"
touch "$systemdPath"
| 21:54:33 |
@janne.hess:helsinki-systems.de | next time I'll just patch systemd instead of doing garbage like this π€ | 21:54:48 |
@elvishjerricco:matrix.org | In reply to @janne.hess:helsinki-systems.de
systemdPath="$(readlink -f "/sysroot$closure/systemd")/lib/systemd/systemd"
mkdir -p "$(dirname "$systemdPath")"
touch "$systemdPath"
o_O what was that for? | 23:19:12 |
@janne.hess:helsinki-systems.de | In reply to @elvishjerricco:matrix.org o_O what was that for? Systemd does a fstatat() onto the new systemd binary. If it's a symlink that doesn't resolve, the switch fails | 23:20:52 |
@elvishjerricco:matrix.org | Oof | 23:21:13 |
| 25 Mar 2022 |
@janne.hess:helsinki-systems.de | If you want to try out the handover, these are the two commits: https://github.com/ElvishJerricco/nixpkgs/compare/systemd-initrd-reuse-systemd-module...helsinki-systems:temp?expand=1 | 10:06:17 |
@janne.hess:helsinki-systems.de | the first commit is already in a PR but the second one isn't because it depends on the PR of the first one being merged | 10:06:35 |
@janne.hess:helsinki-systems.de | Also something to make ElvishJerricco's life (hopefully) easier: https://github.com/NixOS/nixpkgs/pull/165752 | 11:57:50 |
@janne.hess:helsinki-systems.de | The UX is aboslute crap but it's better than nothing | 11:58:02 |
@janne.hess:helsinki-systems.de | nvm, it just landed on master π | 12:34:40 |
bobvanderlinden | Awesome! That is very helpful indeed ππ | 21:40:42 |
| 26 Mar 2022 |
| Andrea Pascal joined the room. | 17:03:13 |
| 27 Mar 2022 |
flokli | ElvishJerricco: can we get https://github.com/NixOS/nixpkgs/pull/164943 finished up and merged? ;-) | 11:28:17 |
| 28 Mar 2022 |
@arianvp:matrix.org | Everything seems resolved no? | 12:49:32 |
@janne.hess:helsinki-systems.de | I'll read over it later today and give it the checkmark of approval if I think it's done ;) Also the classic "if nobody has reasons I shouldn't merge this until β¦" ultimatum while I'm at it :P | 12:50:30 |
@arianvp:matrix.org | Sounds good to me. Currently on my phone but when I have laptop again I'll also give it a green check | 12:51:02 |
@arianvp:matrix.org | (can't find the approval button on the GitHub app lol) | 12:51:12 |
@janne.hess:helsinki-systems.de | It's under "Reviews" | 12:51:23 |
bobvanderlinden | btw, i worked on lvm and luks support a bit: https://github.com/NixOS/nixpkgs/compare/master...bobvanderlinden:pr-systemd-initrd-luks-lvm, not ready for a PR yet, but it looked promising with the experiments i've done in qemu | 13:26:00 |
@elvishjerricco:matrix.org | bobvanderlinden: Awesome. Couple of notes: Why replace coreutils with busybox? IIRC it's not smaller. Also, for LUKS, you don't need to use the full non-minimal systemd. You can do systemdMinimal.override { withCryptsetup = true; } (just probably need to put that in all-packages.nix under some name to make sure it's cached by Hydra). | 18:33:25 |
@arianvp:matrix.org | I'll work on Plymouth at ocean sprint I think | 18:36:05 |
@elvishjerricco:matrix.org | (In fact, I just tried replacing coreutils with busybox, and it's a megabyte larger this way, and I had a collision on the reboot binary) | 18:36:54 |
bobvanderlinden | In reply to @elvishjerricco:matrix.org bobvanderlinden: Awesome. Couple of notes: Why replace coreutils with busybox? IIRC it's not smaller. Also, for LUKS, you don't need to use the full non-minimal systemd. You can do systemdMinimal.override { withCryptsetup = true; } (just probably need to put that in all-packages.nix under some name to make sure it's cached by Hydra). For my use I hated how bash worked in qemu in console mode. It felt quite buggy, as if readline was broken. But I placed it in a separate commit, it's optional. | 19:06:49 |
bobvanderlinden | I haven't optimized on size yet. I first want to see it work, I can optimize once I understand all of the pieces that are needed | 19:07:35 |
bobvanderlinden | I also tried to apply the changes from Janne HeΓ, but couldn't yet get the full boot to work | 19:18:19 |
@janne.hess:helsinki-systems.de | In reply to @bobvanderlinden_:matrix.org I also tried to apply the changes from Janne HeΓ, but couldn't yet get the full boot to work understandable, I had to pick like 20 commits from 40 branches :P I hope the situation gets better when my 2 PRs are in. Once the current "main" PR of this project is in, it should be just one more PR for the full handover | 19:19:10 |
bobvanderlinden | Ah 2 prs? Which ones? | 19:20:09 |
@janne.hess:helsinki-systems.de | well one isn't really necessary, it just makes the diff smaller for the "real" PR | 19:20:39 |
@janne.hess:helsinki-systems.de | Important: https://github.com/NixOS/nixpkgs/pull/165453
Not so important: https://github.com/NixOS/nixpkgs/pull/165684 | 19:20:51 |