| 6 Feb 2024 |
 pwychowaniec | Mic92: I saw you've used to do some code reviews for patchelf, are you still the right person to ping for reviews? 😄 | 19:02:27 |
 Mic92 | Haven't looked at patchelf for a while. Probably should look at it again. It's just super hard to not break anything. | 19:25:54 |
| pwychowaniec | yes, i agree - I'm mostly a Rust programmer nowadays, so RIIR desires were strong in some places there | 19:54:03 |
| pwychowaniec | * yes, i agree - I'm mostly a Rust programmer nowadays, so RIIR desires were strong in some places there 😅 | 19:54:33 |
| Mic92 | Not sure if rusts helps much | 20:27:14 |
| Mic92 | The complexity of the elf format is the issue | 20:27:41 |
 K900 | Rust has some tooling for working with ELF that is very nice | 20:28:09 |
| K900 | Though write support for that isn't fully complete yet | 20:28:22 |
| Mic92 | Parsing is not the issue | 20:28:27 |
| Mic92 | But moving things around | 20:28:39 |
| K900 | I think the right way of doing it would be to parse, modify the parsed representation and serialize | 20:29:06 |
| K900 | Instead of trying to move things around in-place | 20:29:11 |
| 7 Feb 2024 |
| Mic92 | Re-writes would also involve a fair bit of testing/debugging. Don't think I have that much time/motivation. | 08:59:48 |
| K900 | Well we have some pretty great test coverage in "build all of nixpkgs and see what explodes" | 09:01:06 |
| K900 | But yeah, it's hard | 09:01:09 |
| 8 Feb 2024 |
|  Tdr joined the room. | 01:09:05 |
| Mic92 | Yeah I was never short on reproducers but it takes a lot of time to even understand a single one because often it's part of some complex application. | 12:57:11 |
| pwychowaniec | alrighty then, Mic92 could you take a look at https://github.com/NixOS/patchelf/pull/544? 👀
it fixes a long-standing issue in nixpkgs (https://github.com/NixOS/patchelf/issues/482) and also closes a few other patchelf bugs at once
| 17:25:38 |
| 11 Feb 2024 |
 Danila Danko | Mic92, Jonas Chevalier, could you please review https://github.com/numtide/devshell/pull/297, https://github.com/numtide/devshell/pull/290, and https://github.com/numtide/devshell/pull/298? | 11:54:14 |
 Jonas Chevalier | yep, sorry I have been quite busy | 11:59:35 |
| Jonas Chevalier | the changes are quite deep so I need a minute to make a decision | 12:00:06 |
| Mic92 | Maybe Brian can have a look? Not using devshell myself | 12:21:07 |
 raitobezarius | https://buildbot.nix-community.org/#/builders/16/builds/113/steps/1/logs/err_html yet another one in the wild mm | 16:12:01 |
| raitobezarius | (it's possible I'm doing things too fast) | 16:12:05 |
| raitobezarius | (I have been opening a bunch of PRs very quickly and rebasing them very quickly, etc.) | 16:12:17 |
| raitobezarius | I'd like to transfer https://github.com/lukegb/buildcatrust to nix-community BTW (I'm admin on it) | 16:42:39 |
| raitobezarius | can someone confirm me if it's OK to send it there? | 16:42:48 |
| 12 Feb 2024 |
|  Thibaultmol joined the room. | 12:15:23 |
| Mic92 | I think the issue is that github always takes a hot second to compute these merge branches. | 13:29:56 |
| Mic92 | I think I have to switch merge on the CI server instead. | 13:30:09 |
