| 25 Sep 2021 |
 ryantm | I only recently started looking for updatescripts to run. | 01:24:37 |
 adisbladis | Hmm, maybe I could circumvent that | 01:24:48 |
| adisbladis | buildInputs = [ wrapGAppsHook gtk3 gnome.adwaita-icon-theme ]; <- is the only reference to gnome | 01:25:10 |
| adisbladis | So we could just change it in all-packages.nix and inject adwaita-icon-theme separately? | 01:25:37 |
| ryantm | 021-09-11T16:36:36 Old version 90.0b6" not present in master | 01:25:43 |
| ryantm | https://r.ryantm.com/log/updatescript/firefox-beta-bin-unwrapped/2021-09-11.log
| 01:25:57 |
| ryantm | That was the error before the gnome skip | 01:26:14 |
| adisbladis | Hm, that's not really an error though | 01:26:53 |
| adisbladis | ryantm: I mean it shouldn't be. Since the version is not explicitly set in the Nix expression but in the json metadata files | 01:28:53 |
| ryantm | Yeah maybe that check should be ignored for updatescripts ones! | 01:30:04 |
| adisbladis | 👍️ | 01:30:44 |
| adisbladis | ryantm: Looks like that should already be the case?
unless hasUpdateScript do
assertNotUpdatedOn updateEnv derivationFile "master"
assertNotUpdatedOn updateEnv derivationFile "staging"
assertNotUpdatedOn updateEnv derivationFile "staging-next"
| 01:38:27 |
| adisbladis | Ahh, there is another conditional:
when hasUpdateScript do
assertNotUpdatedOn updateEnv' derivationFile "master"
assertNotUpdatedOn updateEnv' derivationFile "staging"
assertNotUpdatedOn updateEnv' derivationFile "staging-next"
| 01:39:43 |
| * adisbladis is not the right person to do this, and especially not right now | 01:42:57 |
| ryantm | So, I think probably it needs to be fixed to not look at the file, but look at the version of the attrpath. | 01:43:24 |
| adisbladis | I was thinking the same | 01:43:50 |
| adisbladis | But my Haskell-fu is weak | 01:43:58 |
| ryantm | It's not going to be super easy to fix, because it was using Git.show to look at other branches, instead of checking them out. | 01:47:28 |
| adisbladis | That's OK, it's not like we're in a hurry :) | 02:27:58 |
| adisbladis | I've removed the references to gnome in the file, so when that version assert is fixed things should start working again | 02:29:06 |
| adisbladis | * I've removed the references to gnome in the file, so when that version assert is fixed things should start working | 02:29:13 |
 Mic92 | now that sops-nix also handles, age encryption, I would start migrating https://github.com/nix-community/infra to it, ok ? | 16:22:00 |
| Mic92 | That means we no longer have missing secrets after reboot | 16:22:31 |
| Mic92 | and we can easier migrate away from sops | 16:22:43 |
| Mic92 | *nixops | 16:22:49 |
| ryantm | ok. | 18:26:07 |
| adisbladis | SGTM | 19:27:00 |
 nix-community-bot | [nix-community/infra] Mic92 pushed to sops-nix: migrate to sops-nix - https://github.com/nix-community/infra/commit/0c07216370ee96155e776b60f52008bc15c9653b | 20:36:27 |
| nix-community-bot | [nix-community/infra] Mic92 opened pull request #124: migrate to sops-nix [open] - https://github.com/nix-community/infra/pull/124 | 20:40:02 |
| nix-community-bot | [nix-community/infra] Mic92 edited pull request #124: migrate to sops-nix [open] - https://github.com/nix-community/infra/pull/124 | 20:47:52 |
