| 28 Jan 2024 |
 K900 | But it still has to build them, link them and run the resulting binary just for it to print "oops no tests lol" | 15:46:24 |
| K900 | Or run like one test in like 0.1 seconds | 15:46:29 |
 @qbit:tapenet.org | well, a number of the tests can be done in parallel: https://github.com/search?q=repo%3Agrafana%2Fgrafana+parallel+path%3Atest&type=code | 15:59:02 |
| @qbit:tapenet.org | so it would probably speed things up by adding it | 15:59:08 |
| K900 | You know what | 16:00:07 |
| K900 | I have cycles | 16:00:09 |
| K900 | I can try it | 16:00:10 |
| @qbit:tapenet.org | also maybe try setting subPackages to just grafana stuff | 16:00:38 |
| K900 | It is all grafana stuff | 16:00:50 |
| K900 | Is the problem | 16:00:51 |
| @qbit:tapenet.org | that will exclude tests in the vendor dir (which is dumb to test anyway) | 16:00:52 |
| @qbit:tapenet.org | it has no deps? | 16:01:21 |
| @qbit:tapenet.org | i highly doubt that | 16:01:26 |
| K900 | I don't think it runs tests for anything in vendor at least | 16:01:45 |
| @qbit:tapenet.org | it does in my experience | 16:02:44 |
| @qbit:tapenet.org | well - builds.. so I assume tests as well | 16:03:08 |
| K900 | Hmm | 16:03:25 |
| K900 | I'm rerunning it with -parallel now | 16:03:37 |
| K900 | We'll see where that goes | 16:03:40 |
 Paul Meyer (katexochen) | In reply to @k900:0upti.me
https://github.com/NixOS/nixpkgs/blob/1e5988ee34cb0c0c5d0db9594f51841455730f54/pkgs/build-support/go/module.nix#L276-L278 This is terrible in general, I'm working on a general rework on how packages to build and test are discovered. | 16:07:25 |
| @qbit:tapenet.org | go test $(go list ./... | grep -v /vendor/) would probably be a good thing to have | 16:09:08 |
| Paul Meyer (katexochen) | In reply to @qbit:tapenet.org
it does in my experience It definitely shouldn't.
https://github.com/NixOS/nixpkgs/blob/e4b4793ffe04112a121d0a23e2010c576bddefdd/pkgs/build-support/go/module.nix#L235 | 16:09:26 |
| @qbit:tapenet.org | nice | 16:09:55 |
| Paul Meyer (katexochen) | In reply to @qbit:tapenet.org
go test $(go list ./... | grep -v /vendor/) would probably be a good thing to have yes, my solution uses go list (but is a bit more sophisticated). | 16:10:10 |
| @qbit:tapenet.org | so find should be go list there probably | 16:10:10 |
| @qbit:tapenet.org | sweet | 16:10:25 |
| Paul Meyer (katexochen) | but it will cause a lot of built failures | 16:10:46 |
| Paul Meyer (katexochen) | as the current way excludes tests in most cases | 16:11:08 |
| Paul Meyer (katexochen) | you can check the following for a preview ;)
https://github.com/katexochen/nixpkgs/commits/buildGoModule/tests/ | 16:11:49 |
| @qbit:tapenet.org | nice | 16:12:07 |
