| 8 Apr 2023 |
@qbit:tapenet.org | Dang - kiddo is sick - will probably be a while before I can get to it | 17:49:01 |
hexa | dfccc488dbbc966a37fc589174daa7323da75e26
4a65e9f64e53fdca6eed31adba836717a11247d2 | 17:53:37 |
hexa | these two commits | 17:53:39 |
hexa | and 500+ usually goes through staging | 17:54:00 |
| Matthew joined the room. | 21:58:13 |
| 11 Apr 2023 |
| j-k joined the room. | 07:52:59 |
j-k | made the PR against staging 22.11 with those commits picked: https://github.com/NixOS/nixpkgs/pull/225733
hope your kid is feeling better qbit :) | 12:02:18 |
@qbit:tapenet.org | Nice! Ty! She is doing better, but we all have Covid :( | 12:06:24 |
j-k | Ouch, hope you all get well soon | 12:08:08 |
@qbit:tapenet.org | Ty | 12:10:41 |
| 12 Apr 2023 |
| jnsgruk joined the room. | 12:57:19 |
hexa | evcc> 2023/04/12 16:46:15 running a test without -tags test
| 16:55:08 |
hexa | why is go like that? | 16:55:10 |
@qbit:tapenet.org | ? | 16:55:48 |
hexa | evcc> buildPhase completed in 2 minutes 38 seconds
evcc> running tests
evcc> ok github.com/evcc-io/evcc/api 0.011s
evcc> 2023/04/12 16:46:15 running a test without -tags test
evcc> FAIL github.com/evcc-io/evcc/charger 0.148s
evcc> FAIL
| 16:56:01 |
hexa | one test succeeds, another one fails, because w/o tags test | 16:56:26 |
@qbit:tapenet.org | hah https://github.com/evcc-io/evcc/blob/master/charger/tags_test.go | 16:58:30 |
hexa | what does all this mean | 17:00:07 |
hexa | I added "test" to tags and it succeeds | 17:00:51 |
@qbit:tapenet.org | means that test is designed to fail 100% of the time, every time | 17:00:52 |
j-k | one file uses the test tag
https://sourcegraph.com/github.com/evcc-io/evcc/-/blob/charger/ocpp_timeouttest.go | 17:01:05 |
@qbit:tapenet.org | oh, ya the go:build line | 17:01:06 |
hexa | comments in go\ | 17:01:29 |
hexa | * comments in go | 17:01:31 |
j-k | to swap out https://sourcegraph.com/github.com/evcc-io/evcc/-/blob/charger/ocpp_timeout.go | 17:01:36 |
hexa | I don't even | 17:01:38 |
hexa | sorry, I'm annoyed | 17:01:58 |
@qbit:tapenet.org | ya, that's a dirty trick | 17:02:12 |
hexa | thanks for the explanation | 17:02:19 |
@qbit:tapenet.org | not specifically a go thing i'd say though | 17:02:22 |