| 26 Jan 2023 |
 Sandro 🐧 | I just noticed that pre/postPatch and postBuild don't apply to vendoring in buildGoModule which was kinda unexpected
https://github.com/NixOS/nixpkgs/pull/212800 | 16:10:24 |
 @qbit:tapenet.org | seems reasonable to me :D | 16:22:53 |
| 27 Jan 2023 |
| @qbit:tapenet.org | Sandro 🐧: Thanks for all the info! | 16:36:14 |
|  jhillyerd joined the room. | 17:29:13 |
| 30 Jan 2023 |
| @qbit:tapenet.org | hihi | 14:21:13 |
| 31 Jan 2023 |
|  @adam:valkor.net joined the room. | 15:22:29 |
| @adam:valkor.net | Is there a way to just add the gomod support to a derivation? Kitty is already a buildPythonApplication derivation, but they've added a go build dependency in the latest release | 15:27:46 |
| @adam:valkor.net | Or is there another way for me to build a derivation combining the two different language envs? | 15:28:23 |
| @qbit:tapenet.org | you could do something like in pkgs/misc/logging/beats/7.x.nix | 15:29:57 |
| @qbit:tapenet.org | is the go source in the kitty repo? | 15:30:30 |
| @qbit:tapenet.org | oh, sorry - i though tbeats was building some other non-go package, looks like they are all go | 15:30:57 |
| @adam:valkor.net | looks like yes https://github.com/kovidgoyal/kitty/tree/master/tools/cli | 15:31:21 |
| @qbit:tapenet.org | maybe just have the go 1.19 compiler available and use the existing derivation ? | 15:33:37 |
| @qbit:tapenet.org | it's not immediately clear where it's actually building the go stuff (nothing obvious in the makefile) | 15:34:10 |
| @adam:valkor.net | the modules aren't vendored though, so it looks like it's failing on pulling them | 15:34:13 |
| @qbit:tapenet.org | ohhh, gross | 15:34:25 |
| @qbit:tapenet.org | maybe have a let theSource = fetchFromGitHub {} and use that in two different derivations? | 15:35:55 |
| @qbit:tapenet.org | not sure how you'd combine it back into one though.. maybe makeWrapper | 15:36:13 |
| @adam:valkor.net | ugh. https://github.com/kovidgoyal/kitty/blob/5a997a5f7a3f28dec1f9675cd434ae6d2c92837a/setup.py#L899 | 15:38:21 |
| @qbit:tapenet.org | gross | 15:39:05 |
| * @qbit:tapenet.org has flashbacks of node-gyp | 15:39:16 |
| Sandro 🐧 | you probably want to build that in an extra derivation and copy over to the python stuff | 17:14:46 |
| @adam:valkor.net | Yeah, that's what I'm working on now | 18:20:04 |
| @adam:valkor.net | ok, here's another question. How can I deal with the improper module name in the go.mod? https://github.com/kovidgoyal/kitty/blob/5a997a5f7a3f28dec1f9675cd434ae6d2c92837a/go.mod#L1 | 20:39:15 |
| @adam:valkor.net | Patch the entire project? Or....? | 20:39:31 |
| @qbit:tapenet.org | uuugh | 20:41:11 |
| @adam:valkor.net | yeah, i will report it upstream as well | 20:41:37 |
| @qbit:tapenet.org | maybe you could do the vendor dance initially (to get the vendor dir), then disable go modules and do the build.. | 20:41:55 |
| @qbit:tapenet.org | maybe.. i am not sure our buildGo stuff will permit that | 20:42:06 |
