| 28 Jan 2024 |
K900 ⚡️ | Like | 15:36:49 |
K900 ⚡️ | It's doing compile-link-run-compile-link-run etc | 15:36:59 |
K900 ⚡️ | When it could be doing multiple packages in parallel | 15:37:12 |
K900 ⚡️ | Tests in different packages can't talk to each other anyway, right? | 15:37:22 |
K900 ⚡️ | I guess they could be touching ambient state | 15:37:29 |
K900 ⚡️ | But we could have an escape hatch for that | 15:37:36 |
@qbit:tapenet.org | They can call other packages | 15:38:16 |
K900 ⚡️ | Wew | 15:38:28 |
K900 ⚡️ | /me looks at 40 minutes of grafana tests | 15:38:41 |
@qbit:tapenet.org | try adding -parallel to the check flags? | 15:45:16 |
K900 ⚡️ | That's not really the problem | 15:45:55 |
K900 ⚡️ | The problem is that it's like 150 packages | 15:46:05 |
K900 ⚡️ | And most of them HAVE NO TESTS | 15:46:09 |
K900 ⚡️ | But it still has to build them, link them and run the resulting binary just for it to print "oops no tests lol" | 15:46:24 |
K900 ⚡️ | Or run like one test in like 0.1 seconds | 15:46:29 |
@qbit:tapenet.org | well, a number of the tests can be done in parallel: https://github.com/search?q=repo%3Agrafana%2Fgrafana+parallel+path%3Atest&type=code | 15:59:02 |
@qbit:tapenet.org | so it would probably speed things up by adding it | 15:59:08 |
K900 ⚡️ | You know what | 16:00:07 |
K900 ⚡️ | I have cycles | 16:00:09 |
K900 ⚡️ | I can try it | 16:00:10 |
@qbit:tapenet.org | also maybe try setting subPackages to just grafana stuff | 16:00:38 |
K900 ⚡️ | It is all grafana stuff | 16:00:50 |
K900 ⚡️ | Is the problem | 16:00:51 |
@qbit:tapenet.org | that will exclude tests in the vendor dir (which is dumb to test anyway) | 16:00:52 |
@qbit:tapenet.org | it has no deps? | 16:01:21 |
@qbit:tapenet.org | i highly doubt that | 16:01:26 |
K900 ⚡️ | I don't think it runs tests for anything in vendor at least | 16:01:45 |
@qbit:tapenet.org | it does in my experience | 16:02:44 |
@qbit:tapenet.org | well - builds.. so I assume tests as well | 16:03:08 |
K900 ⚡️ | Hmm | 16:03:25 |