| 19 Jul 2025 |
 xgwq | Adding preBuild = "git tag v${version}"; adds the right version but still keeps the +dirty. | 23:55:46 |
| 20 Jul 2025 |
 diamond (it/its) | fetchTags = true i think | 03:29:11 |
| diamond (it/its) | although that dirty seems to be because nix patches the package maybe? | 03:29:19 |
| diamond (it/its) | it's doing something w the repo | 03:29:27 |
| diamond (it/its) | you can do preBuild = "git status;"; and see | 03:29:36 |
 katexochen | using fetchgit will result in the source not being reproducible, as it is not possible to get .git deterministic at this point.
I'd suggest to apply a patch or substituteInPlace to make it return the correct version. | 09:16:08 |
| xgwq | That does it. The dirty comes from nix deleting half the repo and untracking the other half. | 10:30:03 |
| diamond (it/its) | In reply to @katexochen:matrix.org
using fetchgit will result in the source not being reproducible, as it is not possible to get .git deterministic at this point.
I'd suggest to apply a patch or substituteInPlace to make it return the correct version. is that true? pkgs.fetchgit still has to be hash locked afaik | 16:38:41 |
 Alyssa Ross | In reply to @diamondburned:matrix.org
is that true? pkgs.fetchgit still has to be hash locked afaik yes but that hash changes sometimes | 18:51:14 |
| Alyssa Ross | it's bad | 18:51:24 |
| Alyssa Ross | if you set leaveDotGit | 18:51:24 |
| diamond (it/its) | ooof | 19:00:52 |
| 21 Jul 2025 |
|  @drupol:matrix.org joined the room. | 17:18:43 |
| @drupol:matrix.org | hellow | 17:18:48 |
| @drupol:matrix.org | I'm going to copy paste a message I wrote in the dev room:
I'm looking for a bit of help for compiling this Go software: https://github.com/NixOS/nixpkgs/pull/427193 (https://github.com/buildpacks/pack). The issue started to appear after they did this: https://github.com/buildpacks/pack/pull/2390
When I run the build, it end up with:
> Building subPackage ./testhelpers
> Building subPackage ./testhelpers/comparehelpers
> Building subPackage ./tools
> main module (github.com/buildpacks/pack) does not contain package github.com/buildpacks/pack/tools
For full logs, run:
nix log /nix/store/8rhs2qy6cbk637czra3lw4ydjh90w6xd-pack-0.38.2.drv
Can you help?
| 17:19:13 |
| @drupol:matrix.org | * I'm going to copy paste a message I wrote in the dev room:
I'm looking for a bit of help for compiling this Go software: https://github.com/NixOS/nixpkgs/pull/427193 (https://github.com/buildpacks/pack). The issue started to appear after they did this: https://github.com/buildpacks/pack/pull/2390 (I added a comment in there just now: https://github.com/buildpacks/pack/pull/2390#issuecomment-3097654347)
When I run the build, it end up with:
> Building subPackage ./testhelpers
> Building subPackage ./testhelpers/comparehelpers
> Building subPackage ./tools
> main module (github.com/buildpacks/pack) does not contain package github.com/buildpacks/pack/tools
For full logs, run:
nix log /nix/store/8rhs2qy6cbk637czra3lw4ydjh90w6xd-pack-0.38.2.drv
Can you help?
| 17:19:38 |
| @drupol:matrix.org | * I'm going to copy paste a message I wrote in the dev room:
I'm looking for a bit of help for compiling pack (https://github.com/buildpacks/pack): https://github.com/NixOS/nixpkgs/pull/427193. The issue started to appear after they did this: https://github.com/buildpacks/pack/pull/2390 (I added a comment in there just now: https://github.com/buildpacks/pack/pull/2390#issuecomment-3097654347)
When I run the build, it end up with:
> Building subPackage ./testhelpers
> Building subPackage ./testhelpers/comparehelpers
> Building subPackage ./tools
> main module (github.com/buildpacks/pack) does not contain package github.com/buildpacks/pack/tools
For full logs, run:
nix log /nix/store/8rhs2qy6cbk637czra3lw4ydjh90w6xd-pack-0.38.2.drv
Can you help?
| 17:21:36 |
| katexochen | Pol: I think you should set subPackages:
subPackages = [ "." ];
| 17:28:43 |
| @drupol:matrix.org | Let me try | 17:28:52 |
| katexochen | The issue is that ./tools is another go module, and buildGoModule can only build packages from one module in one derivation. | 17:29:24 |
| katexochen | If you set subPackages, it will just try to build the package you specified instead of using find and assume it can build everything directory in src that has a .go file. | 17:30:30 |
| @drupol:matrix.org | It worked, thanks !!! | 17:31:06 |
| katexochen | You might want to check if there are other binaries that are expected as output, but I didn't find any at first glance. | 17:31:40 |
| @drupol:matrix.org | Thank you !!! | 17:34:49 |
| @drupol:matrix.org | Ready for review :) | 17:39:01 |
| 23 Jul 2025 |
|  maharshi joined the room. | 14:54:24 |
| 26 Jul 2025 |
|  @okamis:matrix.org left the room. | 20:38:56 |
| 28 Jul 2025 |
|  John joined the room. | 08:03:24 |
| katexochen | Anyone time to review https://github.com/NixOS/nixpkgs/pull/427334 ? | 14:40:53 |
|  @alex:acrawford.com left the room. | 21:29:38 |
