| 12 May 2024 |
diamond (it/its) | this is a really cool project though | 00:03:34 |
@brumik1:matrix.org | I might be mistaken here, but shellHook isnt supposed to be run when entering the shell instead when you build the package? | 09:32:57 |
@brumik1:matrix.org | I do agree the project is really cool dnr! | 09:34:27 |
@brumik1:matrix.org | I ended up with using postFixup. I hope it is not antipattern | 09:47:03 |
dnr | In reply to @diamondburned:matrix.org why? You mean why do it that way? It just seems cleaner to me than using a wrapper. There's just one binary and no script. The disadvantage I guess is that you can't override things by messing with PATH and calling the wrapped binary directly | 19:05:41 |
dnr | And thanks. I've actually been working on an even better version of that idea. I'm planning to announce it soon | 19:07:55 |
| 13 May 2024 |
| Frédéric Christ changed their display name from Frédéric Christ 🌴 29.04.-13.05. to Frédéric Christ. | 14:45:38 |
| 14 May 2024 |
| @kaya:catnip.ee joined the room. | 07:25:31 |
| @azahi:azahi.cc joined the room. | 10:31:33 |
| @kaya:catnip.ee changed their profile picture. | 10:49:24 |
| 15 May 2024 |
| @raboof:matrix.org joined the room. | 12:00:55 |
@raboof:matrix.org | hi! I'm trying to run guac. made a first stab at it in https://github.com/raboof/guac/commit/b4251b9719e98e2a8b689088d71304d36250019d , but building it gives me some errors like cannot find module providing package github.com/aws/aws-sdk-go-v2/aws/protocol/xml: import lookup disabled by -mod=vendor. Indeed they don't seem to be in the gomod2nix.toml generated by gomod2nix generate. Any ideas what could be the matter? | 12:02:48 |
@raboof:matrix.org | github.com/aws/aws-sdk-go-v2/aws/protocol/xml indeed isn't in go.sum, even after go mod tidy | 12:36:45 |
Paul Meyer (katexochen) | In reply to @raboof:matrix.org
github.com/aws/aws-sdk-go-v2/aws/protocol/xml indeed isn't in go.sum, even after go mod tidy Well, that's not a module but a package, right? https://github.com/aws/aws-sdk-go-v2/tree/v1.26.1/aws/protocol/xml Seems to belong to the module github.com/aws/aws-sdk-go-v2 | 12:46:41 |
@raboof:matrix.org | gotcha - sorry, my go is rusty (no pun intended 😆). that's a good lead, digging further. | 13:05:20 |
@raboof:matrix.org | https://github.com/nix-community/gomod2nix/pull/158 🎉 | 14:07:48 |
| 16 May 2024 |
| Frédéric Christ changed their display name from Frédéric Christ to Frédéric Christ 🌴 17.05.. | 14:30:07 |
| @anjoletto:matrix.org left the room. | 21:04:56 |
| 17 May 2024 |
hexa | does the go builder have an interface for disabling tests? | 08:21:48 |
hexa | I've usually gone and just yeeted individual test files, which seems rather coarse | 08:22:04 |
Paul Meyer (katexochen) | https://nixos.org/manual/nixpkgs/unstable/#ssec-skip-go-tests | 08:22:47 |
Paul Meyer (katexochen) | Not really, but letting Go skip test cases is slightly cleaner and less error prone than removing test files. | 08:23:48 |
Paul Meyer (katexochen) | Already thought about moving that into an input, but not sure it is worth it. | 08:24:44 |
Paul Meyer (katexochen) | * hexa: https://nixos.org/manual/nixpkgs/unstable/#ssec-skip-go-tests | 08:25:06 |
hexa | ah neat, thanks for pointing that out | 08:25:32 |
hexa | and yeah, if that code is well tested, port it into the builder | 08:36:40 |
hexa | makes people less likely to apply crude hacks | 08:37:06 |
hexa | in python we have pytestFlagsArray and on top of that disabledTests and disabledTestsPath fwiw | 08:37:44 |
hexa | that would map to checkFlags and skippedTests | 08:37:58 |
| 18 May 2024 |
| easel set a profile picture. | 12:27:42 |