| 25 Sep 2023 |
Artturin | In reply to @katexochen:matrix.org Why is buildGoModule using vendoring instead of relying on go.mod/go.sum? vendoring would be copying those files to the nixpkgs repo | 05:12:26 |
Artturin | and they're not | 05:13:14 |
Paul Meyer (katexochen) | The builder has a field vendorHash, that's what I'm talking about. As far as I understand, it creates a intermediate derivation with the vendored dependencies. | 05:14:32 |
Artturin | I consider vendoring copying files to the repo | 05:15:10 |
Paul Meyer (katexochen) | * The builder has a field vendorHash, that's what I'm talking about. As far as I understand, it creates an intermediate derivation with the vendored dependencies. | 05:15:11 |
Artturin | the vendorHash thingy is just for a fod | 05:15:25 |
Artturin | so the deps can be fetched | 05:15:29 |
Paul Meyer (katexochen) | fod? | 05:18:44 |
Artturin | fixed output derivation | 05:18:52 |
Artturin | only those and impure derivations have access to network | 05:19:00 |
Paul Meyer (katexochen) | Sure, makes sense to separate those derivations. But couldn't it use the go.sum file instead of its own hash? How would I validate the vendorHash actually is the hash of the dependencies in the go.sum file? | 05:22:52 |
Artturin | In reply to @katexochen:matrix.org Sure, makes sense to separate those derivations. But couldn't it use the go.sum file instead of its own hash? How would I validate the vendorHash actually is the hash of the dependencies in the go.sum file? Using a file from inside the derivation would be ifd | 05:26:48 |
Artturin | Import from derivation | 05:26:55 |
Artturin | Which isn't allowed in nixpkgs | 05:27:14 |
Artturin | Files would have to be downloaded during evaluation | 05:27:25 |
Paul Meyer (katexochen) | Got it, thanks for explaining. So dynamic derivations could potentially fix this in nixpkgs? | 05:29:43 |
Paul Meyer (katexochen) | But isn't go vendor using the go.mod file from inside the derivation anyway to download the dependencies? | 05:32:56 |
Paul Meyer (katexochen) | I mean how else would it know what to download. | 05:33:40 |
Artturin | In reply to @katexochen:matrix.org But isn't go vendor using the go.mod file from inside the derivation anyway to download the dependencies? You can check the builders nix file and see what it runa | 05:34:11 |
Artturin | * In reply to @katexochen:matrix.org
But isn't go vendor using the go.mod file from inside the derivation anyway to download the dependencies?
You can check the builders nix file and see what it runs | 05:34:17 |
Artturin | In reply to @katexochen:matrix.org Got it, thanks for explaining. So dynamic derivations could potentially fix this in nixpkgs? The rfc summary says so | 05:34:54 |
@qbit:tapenet.org | In reply to @katexochen:matrix.org But isn't go vendor using the go.mod file from inside the derivation anyway to download the dependencies? the vendor derivation is built first, then the hash is put in the buildGoModule derivation | 12:39:17 |
@qbit:tapenet.org | and afaik the reason it was done this way is because the hashes are non-compat | 12:39:38 |
| 26 Sep 2023 |
| maka-77x joined the room. | 00:11:04 |
| 27 Sep 2023 |
| mib 🥐 changed their display name from mib to mib 🥐. | 05:53:08 |
| 29 Sep 2023 |
| calebwoodbine joined the room. | 20:09:41 |
| calebwoodbine changed their display name from bobymcbobs to calebwoodbine. | 20:16:30 |
| 6 Oct 2023 |
| chrispickard set their display name to chrispickard. | 13:39:19 |
| 8 Oct 2023 |
| K900 joined the room. | 18:47:42 |
K900 | Can someone with more nixpkgs/go stuff experience tell me if there's a less shitty way to do https://github.com/NixOS/nixpkgs/pull/259815 | 18:48:12 |