!QCCCSJHEsTIfozrZxz:nixos.org

Nix + Go

222 Members
Go packaging for and with Nixpkgs. | Be excellent to each other.54 Servers

Load older messages


SenderMessageTime
25 Sep 2023
@artturin:matrix.orgArtturin
In reply to @katexochen:matrix.org
Why is buildGoModule using vendoring instead of relying on go.mod/go.sum?
vendoring would be copying those files to the nixpkgs repo
05:12:26
@artturin:matrix.orgArtturinand they're not05:13:14
@katexochen:matrix.orgPaul Meyer (katexochen)The builder has a field vendorHash, that's what I'm talking about. As far as I understand, it creates a intermediate derivation with the vendored dependencies.05:14:32
@artturin:matrix.orgArtturinI consider vendoring copying files to the repo05:15:10
@katexochen:matrix.orgPaul Meyer (katexochen)* The builder has a field vendorHash, that's what I'm talking about. As far as I understand, it creates an intermediate derivation with the vendored dependencies.05:15:11
@artturin:matrix.orgArtturinthe vendorHash thingy is just for a fod05:15:25
@artturin:matrix.orgArtturinso the deps can be fetched05:15:29
@katexochen:matrix.orgPaul Meyer (katexochen)fod?05:18:44
@artturin:matrix.orgArtturinfixed output derivation05:18:52
@artturin:matrix.orgArtturinonly those and impure derivations have access to network05:19:00
@katexochen:matrix.orgPaul Meyer (katexochen)Sure, makes sense to separate those derivations. But couldn't it use the go.sum file instead of its own hash? How would I validate the vendorHash actually is the hash of the dependencies in the go.sum file? 05:22:52
@artturin:matrix.orgArtturin
In reply to @katexochen:matrix.org
Sure, makes sense to separate those derivations. But couldn't it use the go.sum file instead of its own hash? How would I validate the vendorHash actually is the hash of the dependencies in the go.sum file?
Using a file from inside the derivation would be ifd
05:26:48
@artturin:matrix.orgArtturinImport from derivation05:26:55
@artturin:matrix.orgArtturinWhich isn't allowed in nixpkgs05:27:14
@artturin:matrix.orgArtturinFiles would have to be downloaded during evaluation05:27:25
@katexochen:matrix.orgPaul Meyer (katexochen)Got it, thanks for explaining. So dynamic derivations could potentially fix this in nixpkgs?05:29:43
@katexochen:matrix.orgPaul Meyer (katexochen)But isn't go vendor using the go.mod file from inside the derivation anyway to download the dependencies?05:32:56
@katexochen:matrix.orgPaul Meyer (katexochen)I mean how else would it know what to download.05:33:40
@artturin:matrix.orgArtturin
In reply to @katexochen:matrix.org
But isn't go vendor using the go.mod file from inside the derivation anyway to download the dependencies?
You can check the builders nix file and see what it runa
05:34:11
@artturin:matrix.orgArtturin* In reply to @katexochen:matrix.org But isn't go vendor using the go.mod file from inside the derivation anyway to download the dependencies? You can check the builders nix file and see what it runs05:34:17
@artturin:matrix.orgArtturin
In reply to @katexochen:matrix.org
Got it, thanks for explaining. So dynamic derivations could potentially fix this in nixpkgs?
The rfc summary says so
05:34:54
@qbit:tapenet.org@qbit:tapenet.org
In reply to @katexochen:matrix.org
But isn't go vendor using the go.mod file from inside the derivation anyway to download the dependencies?
the vendor derivation is built first, then the hash is put in the buildGoModule derivation
12:39:17
@qbit:tapenet.org@qbit:tapenet.organd afaik the reason it was done this way is because the hashes are non-compat12:39:38
26 Sep 2023
@maka-mmparr77:matrix.orgmaka-77x joined the room.00:11:04
27 Sep 2023
@mib:kanp.aimib 🥐 changed their display name from mib to mib 🥐.05:53:08
29 Sep 2023
@bobymcbobs:matrix.orgcalebwoodbine joined the room.20:09:41
@bobymcbobs:matrix.orgcalebwoodbine changed their display name from bobymcbobs to calebwoodbine.20:16:30
6 Oct 2023
@chrispickard:matrix.orgchrispickard set their display name to chrispickard.13:39:19
8 Oct 2023
@k900:0upti.meK900 joined the room.18:47:42
@k900:0upti.meK900Can someone with more nixpkgs/go stuff experience tell me if there's a less shitty way to do https://github.com/NixOS/nixpkgs/pull/25981518:48:12

Show newer messages


Back to Room ListRoom Version: 9