| 31 Mar 2025 |
@hexa:lossy.network | https://github.com/tlyakhov/python-decora_wifi/blob/faaff1ddf2e4c0676fa3bccfbf1639372694b4b5/setup.py#L26 | 12:29:06 |
@hexa:lossy.network | per this you need to configure dependencies with requests and inflect | 12:29:26 |
continous | That's odd, someone commented removing the dependencies section on my code. | 12:30:16 |
@hexa:lossy.network | checking | 12:34:08 |
@hexa:lossy.network | have you tried building the package? | 12:35:03 |
@hexa:lossy.network | decora_wifi/__init__.py
11:import requests
23: self._session = requests.Session()
| 12:35:16 |
@hexa:lossy.network | because it surely requires requests | 12:35:23 |
continous | Yeah it doesn't build now and I couldn't figure out why. The original code worked with dependencies so I'm trying it with dependencies readded. | 12:36:18 |
continous | My sloppy built solution that I initial input had requests as a build input. | 12:37:25 |
continous | * My sloppy built solution that I initial submitted had requests as a build input. | 12:37:33 |
continous | Dependencies fix worked 👍️ | 12:38:39 |
continous | I didn't import inflect in my sloppy initial work, but I'm going to do so now just in case. | 12:39:01 |
continous | On a scale of 0-100 how bad is a commit with no changes 😅 | 12:50:21 |
K900 | Why would you make a commit with no changes? | 12:52:06 |
continous | To have the 3 requested commit messages. | 12:52:26 |
continous | I feel bad because everyone has been so helpful and I'm just bumbling about in comparison | 12:53:06 |
@hexa:lossy.network | each commit has a meaning, and as such must have a change | 12:53:54 |
@hexa:lossy.network | if it does not it is because you included the change in an unrelated commit already | 12:54:07 |
continous | Yup. I guest I can split the old commit instead. | 12:54:36 |
continous | Again, I really appreciate everyone's help. | 12:54:52 |
K900 | Yeah, the point of having three commits is not to have three commits | 13:01:08 |
K900 | Is to give every change its own separate description | 13:01:18 |
continous | So then, you'd want each commit to be relegated to it's own specific changes. Right now I'm basically there then | 13:08:15 |
| susagi joined the room. | 16:12:59 |
continous | I think I've finalized my pull request. If someone would be kind enough to give it a second look over for a sanity check for me that'd be much appreciated. | 18:02:48 |
| 1 Apr 2025 |
@hexa:lossy.network | https://newsletter.openhomefoundation.org/ai-voice-control-at-what-cost/ | 01:39:17 |
K900 | When's 2025.4 BTW | 01:50:35 |
K900 | I want to drop my soundbar hacks | 01:50:51 |
@hexa:lossy.network | tomorrow | 01:53:03 |
@hexa:lossy.network | first wednesday of the month | 01:53:11 |