| 24 Jan 2025 |
@hexa:lossy.network | I made a bunch of changes based on homeassistant-addons | 16:10:55 |
@hexa:lossy.network | but I only approximated them and merged after two days without review | 16:11:04 |
@hexa:lossy.network | and obviously I made errors in that 🫣 | 16:11:11 |
@hexa:lossy.network | ok, this is stupid | 16:12:55 |
@hexa:lossy.network | data dir is required | 16:13:23 |
@hexa:lossy.network | download dir is optional | 16:13:27 |
@hexa:lossy.network | and if you set a download dir, then it does not move anything to the datadir | 16:13:46 |
@hexa:lossy.network | nor does it use the download dir as a datadir | 16:13:54 |
@hexa:lossy.network | all of this is fckd | 16:13:59 |
@hexa:lossy.network | faster-whisper has the same pattern, wondering if it is fckd there as well | 16:22:59 |
laurynasp | faster-whisper works without any problems for me (using model medium-int8) | 16:27:17 |
@hexa:lossy.network | so maybe some code to port over | 16:31:57 |
@hexa:lossy.network | ok so | 17:22:12 |
@hexa:lossy.network | https://github.com/search?q=repo%3Arhasspy%2Fwyoming-faster-whisper%20data_dir&type=code | 17:22:13 |
@hexa:lossy.network | I don't get it | 17:22:15 |
@hexa:lossy.network | the data dir is mandatory | 17:23:35 |
@hexa:lossy.network | if no download dir is set, the first data dir becomes the download dir | 17:23:50 |
@hexa:lossy.network | the download dir is passed on | 17:24:01 |
@hexa:lossy.network | the data dir … isn't | 17:24:04 |
@hexa:lossy.network | lmao | 17:24:05 |
@hexa:lossy.network | https://github.com/home-assistant/addons/blob/master/piper/rootfs/etc/s6-overlay/s6-rc.d/piper/run#L26C1-L28C25 | 17:25:15 |
@hexa:lossy.network | for piper they pass multiple data dirs, one of which is the download dir | 17:25:23 |
@hexa:lossy.network | https://github.com/home-assistant/addons/blob/master/whisper/rootfs/etc/s6-overlay/s6-rc.d/whisper/run#L32-L33 | 17:25:48 |
@hexa:lossy.network | the same for faster-whisper | 17:25:52 |
@hexa:lossy.network | so the --download-dir is useless | 17:26:13 |
@hexa:lossy.network | just pass a --data-dir | 17:26:18 |
@hexa:lossy.network | https://github.com/NixOS/nixpkgs/pull/376447 | 17:29:31 |
laurynasp | Thanks hexa for pushing a fix so quickly | 18:20:23 |
@hexa:lossy.network | thanks for appreciating my contributions | 18:20:52 |
laurynasp | Redacted or Malformed Event | 18:24:49 |