| 17 Dec 2024 |
@hexa:lossy.network | https://github.com/NixOS/nixpkgs/pull/365730 | 00:11:10 |
@hexa:lossy.network | interacting with this ecosystem for these kinds of issues is pretty much pointless | 00:11:27 |
ibizaman | Thank you! And sorry for the circumvented way to get to a fix. | 00:17:46 |
@hexa:lossy.network | - PyChromecast==14.0.4 not satisifed by version 14.0.5
- pycryptodome==3.21.0 not satisifed by version 3.20.0
- py-opensonic==5.1.1 not satisifed by version 5.2.1
- plexapi==4.15.16 not satisifed by version 4.16.0
- radios==0.3.1 not satisifed by version 0.3.2
- soco==0.30.5 not satisifed by version 0.30.6
- defusedxml==0.7.1 not satisifed by version 0.8.0rc2
- tidalapi==0.8.0 not satisifed by version 0.7.6
- ytmusicapi==1.8.1 not satisifed by version 1.8.2
- yt-dlp==2024.10.7 not satisifed by version 2024.12.6
| 00:22:06 |
@hexa:lossy.network | so basically all pins are outdated 🥳 | 00:22:21 |
@hexa:lossy.network | * so basically all pins are off 🥳 | 00:23:07 |
@hexa:lossy.network | so many problems to resolve and only so much time in a day | 00:23:42 |
@hexa:lossy.network | I think we should relax the check in mass and depend only fail on too old versions | 00:27:17 |
@hexa:lossy.network | * I think we should relax the check in mass and only fail on too old versions | 00:29:19 |
mjm | i have this patch for music-assistant in my config: https://git.midna.dev/mjm/nix-config/-/blob/main/packages/music-assistant/ma-no-install.patch?ref_type=heads
felt a little too gross for me to want to send to nixpkgs but i wasn't sure a better way | 03:08:13 |
@hexa:lossy.network | the problem is … i started packaging it because I was curious | 03:16:23 |
@hexa:lossy.network | it didn't work out too well for local files as I had hoped | 03:16:38 |
@hexa:lossy.network | someone asked for it, so I PRed it | 03:16:47 |
@hexa:lossy.network | and here we are | 03:16:50 |
@hexa:lossy.network | for home-assistant we ended up making the tests top-level attributes, so that dependency bumps would run them | 03:22:43 |
@hexa:lossy.network | but music-assistant hardly has any tests for specific providers, just filesystem and jellyfin | 03:23:02 |
@hexa:lossy.network | I'll look into how to best patch out the behavior tomorrow | 03:24:08 |
@hexa:lossy.network |  Download image.png | 03:41:10 |
@hexa:lossy.network | diff --git a/music_assistant/server/helpers/util.py b/music_assistant/server/helpers/util.py
index 3d342b73..a395fb46 100644
--- a/music_assistant/server/helpers/util.py
+++ b/music_assistant/server/helpers/util.py
@@ -117,30 +117,11 @@ async def load_provider_module(domain: str, requirements: list[str]) -> Provider
def _get_provider_module(domain: str) -> ProviderModuleType:
return importlib.import_module(f".{domain}", "music_assistant.server.providers")
- # ensure module requirements are met
- for requirement in requirements:
- if "==" not in requirement:
- # we should really get rid of unpinned requirements
- continue
- package_name, version = requirement.split("==", 1)
- installed_version = await get_package_version(package_name)
- if installed_version == "0.0.0":
- # ignore editable installs
- continue
- if installed_version != version:
- await install_package(requirement)
-
# try to load the module
try:
return await asyncio.to_thread(_get_provider_module, domain)
except ImportError:
- # (re)install ALL requirements
- for requirement in requirements:
- await install_package(requirement)
- # try loading the provider again to be safe
- # this will fail if something else is wrong (as it should)
- return await asyncio.to_thread(_get_provider_module, domain)
-
+ raise RuntimeError(f"Missing dependencies for provider {domain}.")
def create_tempfile():
"""Return a (named) temporary file."""
| 03:41:46 |
@hexa:lossy.network | so we even get a nice toast 😛 | 03:41:51 |
mjm | yeah that's a little better than what i did :D | 04:57:08 |
mjm | it was annoying because it seemed like that code was changing a lot when i was trying to make the patch. i was worried it would be hard to maintain but i haven't had to change it so far | 04:57:43 |
@hexa:lossy.network | https://www.home-assistant.io/blog/2024/12/16/community-survey-2024/ | 14:03:57 |
| 18 Dec 2024 |
spacekitteh | oh hell yeah, i got the openthread border router building and working with the web frontend finally :D | 03:32:56 |
spacekitteh | lmao it's like they know | 03:35:02 |
spacekitteh |  Download image.png | 03:35:06 |
spacekitteh | i guess i should have read the blog post, they explicitly mention neurodivergency shrugs | 03:39:08 |
spacekitteh | ok, a few more tweaks and i think i'll be ready to make a PR for my openthread border router module :3 | 05:25:58 |
netpleb | I am trying to get confirmable notifications working. I have regular notifications working just fine. Do I need to do anything special to enable saving of scripts? I seem to be able to "create" and "save" a script from the confirmable notification blueprint, but then the script does not appear anywhere for me to use. It's like the save button did nothing. Any idea hexa ? | 23:44:11 |
@hexa:lossy.network | no idea | 23:53:44 |