| 27 Jun 2021 |
 dotlambda | Is it a good idea that the NixOS test uses the package with tests enabled? | 15:51:14 |
| dotlambda | In reply to @hexa:lossy.network
currently bisecting home-assistant nixos test breakaged Did the bisecting give a meaningful result? | 16:04:20 |
 @hexa:lossy.network | Too many false positives due to python-unstablr | 16:11:27 |
| dotlambda | Could jinja2 be the reason? | 16:22:20 |
| @hexa:lossy.network | In reply to @robert:funklause.de
Is it a good idea that the NixOS test uses the package with tests enabled? Yes, because ofBorg runs the tests as passthrough.tests, so we execute the package tests that way as well | 16:25:25 |
| @hexa:lossy.network | but for bisecting I commented the package setting in the test | 16:25:38 |
| dotlambda | Yeah i'm pretty sure that 19581cb9619d58f76e10293b7a57aaf477db28d9 is the culprit. | 16:25:43 |
| @hexa:lossy.network | nice | 16:26:13 |
| @hexa:lossy.network | yeah, propagating setuptools from there was weird | 16:26:21 |
| @hexa:lossy.network | so let's add setuptools to home assistant and be done with it I guess. | 16:27:21 |
| @hexa:lossy.network |
❯ rg setuptools
setup.py
5:from setuptools import find_packages, setup
| 16:27:46 |
| @hexa:lossy.network | only mention of setuptools in hass/core | 16:27:54 |
| dotlambda | In reply to @hexa:lossy.network
Yes, because ofBorg runs the tests as passthrough.tests, so we execute the package tests that way as well ofborg also builds home-assistant, that runs the tests | 16:28:16 |
| dotlambda | In reply to @hexa:lossy.network
only mention of setuptools in hass/core pkg_resources is usually what is the run-time dependency | 16:28:38 |
| @hexa:lossy.network | so it should be cached? | 16:29:31 |
| dotlambda | What do you mean? | 16:31:04 |
| @hexa:lossy.network | if it is built by ofborg it is probably cached, when the tests run | 16:31:20 |
| dotlambda | In reply to @hexa:lossy.network
if it is built by ofborg it is probably cached, when the tests run oh yeah indeed, but building it without tests is cheap | 16:31:55 |
| @hexa:lossy.network | true, but it would be a second package build I guess? | 16:32:25 |
| dotlambda | We lose testing whether our default option for services.home-assistant.package works though. | 16:32:30 |
| @hexa:lossy.network | yeah, I don't mind either way | 16:32:42 |
| @hexa:lossy.network | i run the tests often enough | 16:32:49 |
| dotlambda | Will you make the PR adding setuptools? | 16:33:17 |
| dotlambda | In reply to @hexa:lossy.network
dotlambda: Fabian Affolter I'm tired big time, day after vaccination, so don't expect much from me 😵 Congrats on getting vaccinated btw! | 16:36:14 |
| @hexa:lossy.network | I'm a bit numb | 16:36:29 |
| @hexa:lossy.network | it's day n+1 | 16:36:41 |
| @hexa:lossy.network | so please just do it yourself :) | 16:36:50 |
| dotlambda | I didn't feel anything until I got really sick on day n+6, but that must have been unrelated. | 16:37:31 |
| dotlambda | In reply to @hexa:lossy.network
so please just do it yourself :) It's ready, just waiting on the build to finish. | 16:41:45 |
| dotlambda | * It's ready, just waiting for the build to finish. | 16:41:53 |
