16 Dec 2024 |
hexa | my dude | 23:27:34 |
hexa | we don't have that dependency | 23:27:38 |
hexa | your answers are super inconsistent 😕 | 23:27:44 |
ibizaman | https://github.com/music-assistant/server/blob/c33e766ec4062ac9b812d31968fe3393bada4df6/music_assistant/helpers/util.py#L437-L438 | 23:27:44 |
hexa | give me the error for an installed provider please | 23:28:13 |
ibizaman | In reply to @hexa:lossy.network your answers are super inconsistent 😕 Sry that's because I'm confused 🙏 | 23:28:26 |
hexa | and yes, that version check is probably problematic | 23:28:33 |
ibizaman | In reply to @hexa:lossy.network give me the error for an installed provider please This is what I get from trying to add hass:
Dec 16 23:28:58 baryum mass[1779974]: 2024-12-16 23:28:58.937 ERROR (MainThread) [music_assistant.webserver] Error handling message: config/providers/get_entries: [Errno 2] No such file or directory: 'uv'
But IMO that doesn't help because it doesn't show why it's trzying to call uv
| 23:30:08 |
hexa | ok, but for what dep? | 23:31:05 |
ibizaman | In reply to @hexa:lossy.network ok, but for what dep? To know that, I hacked by adding uv to the optional-dependencies of music-assistant/package.nix, then it goes one step further and shows this error:
Dec 16 23:33:59 baryum mass[1784227]: 2024-12-16 23:33:59.346 ERROR (MainThread) [music_assistant.webserver] Error handling message: config/providers/get_entries: Failed to install package hass-client==1.2.0
Dec 16 23:33:59 baryum mass[1784227]: error: No virtual environment found; run `uv venv` to create an environment, or pass `--system` to install into a non-virtual environment
| 23:34:19 |
hexa | we have that exact version on master | 23:36:33 |
hexa | since 2024-09-06 | 23:36:57 |
hexa | so also on nixos-24.11 | 23:37:03 |
ibizaman | Gosh, annoying you for that is embarrassing, to say the least... let me try an update. Btw I am/was on a 1 month old commit. | 23:39:04 |
hexa | ok, version mismatch | 23:54:28 |
hexa | so now I wonder why | 23:54:49 |
hexa |
[music_assistant.server.helpers.util] DEBUG: 1.0.0 != 1.2.0
| 23:54:55 |
hexa | lib/python3.12/site-packages/hass_client-1.0.0.dist-info/LICENSE | 23:55:25 |
hexa | the package version is off. | 23:55:32 |
hexa | https://github.com/music-assistant/python-hass-client/blob/1.2.0/pyproject.toml#L17 | 23:55:55 |
hexa | because of course they refer to the wrong version on the tag | 23:56:04 |
hexa | only to patch it in the publish step https://github.com/music-assistant/python-hass-client/blob/main/.github/workflows/publish-to-pypi.yml#L34 | 23:56:50 |
hexa | lib/python3.12/site-packages/hass_client-1.2.0.dist-info/
| 23:57:10 |
ibizaman | wow | 23:58:08 |
17 Dec 2024 |
ibizaman | I'd like to propose a PR for the repo but was wondering what would work with Nix. I see they're trying to be clever by using the tag to set the version, so they only have one source of truth. I can come up with a way to do the opposite and create a git tag automatically whenever the pyproject.toml version changes. But then, that's quite a lot of code and would need buy-in from upstream. Is this worth it in your opinion? Is there a less nice but still maintainable way to get around this issue? | 00:09:53 |
hexa | don't bother, already fixed | 00:11:05 |
hexa | https://github.com/NixOS/nixpkgs/pull/365730 | 00:11:10 |
hexa | interacting with this ecosystem for these kinds of issues is pretty much pointless | 00:11:27 |
ibizaman | Thank you! And sorry for the circumvented way to get to a fix. | 00:17:46 |
hexa | - PyChromecast==14.0.4 not satisifed by version 14.0.5
- pycryptodome==3.21.0 not satisifed by version 3.20.0
- py-opensonic==5.1.1 not satisifed by version 5.2.1
- plexapi==4.15.16 not satisifed by version 4.16.0
- radios==0.3.1 not satisifed by version 0.3.2
- soco==0.30.5 not satisifed by version 0.30.6
- defusedxml==0.7.1 not satisifed by version 0.8.0rc2
- tidalapi==0.8.0 not satisifed by version 0.7.6
- ytmusicapi==1.8.1 not satisifed by version 1.8.2
- yt-dlp==2024.10.7 not satisifed by version 2024.12.6
| 00:22:06 |