!RROtHmAaQIkiJzJZZE:nixos.org

NixOS Infrastructure

395 Members
Next Infra call: 2024-07-11, 18:00 CEST (UTC+2) | Infra operational issues backlog: https://github.com/orgs/NixOS/projects/52 | See #infra-alerts:nixos.org for real time alerts from Prometheus.120 Servers

Load older messages


SenderMessageTime
19 Feb 2026
@toonn:matrix.orgtoonn The required permission is still "members: write". 16:41:40
@emilazy:matrix.orgemilyright, of course16:53:52
@emilazy:matrix.orgemily (I mean, not actually because you can just assign a maintainer for the nixpkgs-maintainers team) 16:54:15
@emilazy:matrix.orgemily(but our CI already has write permissions to Nixpkgs)16:54:23
@toonn:matrix.orgtoonn Would it need to write to Nixpkgs? To update handles in the maintainer list, I guess? Can you assign a GH Action as a maintainer? Repository permissions aren't enough to do organization changes, no? 16:58:49
@emilazy:matrix.orgemilyRFC39 bot doesn't write to Nixpkgs, no17:07:14
@emilazy:matrix.orgemilyI believe you can assign bot accounts as team maintainers, although I'm not 100% on the nuance with GitHub Apps there.17:07:47
@joerg:thalheim.ioMic92 BMG in case you want to join: https://meet.cccda.de/nix-osin-fra 17:18:06
@toonn:matrix.orgtoonn It doesn't? Does it open a PR instead then to update maintainer handles? 17:21:48
@emilazy:matrix.orgemilyit doesn't update maintainer handles17:23:40
@emilazy:matrix.orgemilyat least not that I've ever seen17:23:52
@emilazy:matrix.orgemily(it couldn't do it via direct push anyway since we don't allow those)17:24:09
@toonn:matrix.orgtoonn It claims to though. 17:24:18
@toonn:matrix.orgtoonn Or at least RFC 39 says it should : ) 17:24:28
@emilazy:matrix.orgemilyI don't see that in the text. it just says that handles should be updated in general, not that a bot should do it17:26:28
@toonn:matrix.orgtoonn Looks like it was aspirational "Somewhat half-hearted attempt at checking all the handles and IDs, but it doesn't really work right now." 17:28:23
@toonn:matrix.orgtoonn For an action to add members to the organization (since that's a requisite for team membership) or a team it'd need a token from an app with the "members: write" permission. I assume the app would be an empty shell to carry the token with the permission. Then the action can do API requests using the token, parse the maintainers list, get nixpkgs-maintainers membership through the API and 17:33:20
@toonn:matrix.orgtoonn invite missing maintainers to the org/team using another API request. 17:33:27
@emilazy:matrix.orgemilythe app for CI already exists and has write access to Nixpkgs (so there would be no further exposure than we already have)17:36:47
@toonn:matrix.orgtoonn I'm not sure why you insist on the Nixpkgs write access. Repository access is not enough, "members: write" is an organization level permission. 17:39:39
@emilazy:matrix.orgemilyI am explaining that we already have a GitHub App hooked up to our GitHub Actions CI, and it already has write access to Nixpkgs, so the risk that a bot that can manage teams could lead to privilege escalation into Nixpkgs writes isn't any increase in the surface of the risk the app we already have already provides to our automation17:40:53
@toonn:matrix.orgtoonn Least priviledge would suggest having separate apps with strictly necessary permissions but storing multiple tokens in GitHub secrets means actions can access all of the permissions anyway. 17:41:23
@emilazy:matrix.orgemilythe reason "members: write" is dangerous is because it's equivalent to Nixpkgs commit access, nothing else you can do with it is remotely as risky17:41:52
@emilazy:matrix.orgemilyyou can offer different secrets to different workflows, but because of ^ I doubt it'd be that worthwhile. anyway, ideally it just uses team maintainership anyway. my point was only that it's not an increase in effective attack surface17:42:42
@toonn:matrix.orgtoonn The equivalence is useful to point out but I never tried to say it's a problem. 17:45:04
@toonn:matrix.orgtoonn I'm not sure team maintainership can be passed along through a token. 17:45:36
@gabyx:matrix.orggabyxIs rfc39 running currently?17:55:52
@toonn:matrix.orgtoonn AFAIK it is, new maintainers still get invites. Often they expire but then they come to the org owners room to ask for a new invite. 17:58:14
@hexa:lossy.networkhexa all the time 18:14:22
@hexa:lossy.networkhexaevery 30 minutes18:14:35

Show newer messages


Back to Room ListRoom Version: 6