| 1 Mar 2025 |
hexa | supposedly this https://github.com/ROCm/AMDMIGraphX/blob/develop/src/py/migraphx_py.cpp | 07:13:00 |
Lun | Mention it on the big ROCm tracking issue | 16:04:24 |
Lun | definitely worse: https://gist.githubusercontent.com/LunNova/b1cf007f1af52b4dc353fd9925857b97/raw/63ea9ec1a500d5ef6ad4f2f0eac7a59b6db6e310/huge%2520composable_kernel%2520template%2520instantiation.txt | 16:07:29 |
Lun | The ~4h builds are nix cores config set to 128 on a 64c/128t epyc milan eng sample that's clocking down to <3GHz due to power limits, not sure what the relative speedup per core will be but probably not enough to overcome dropping to 24 build threads.
Does bumping meta.timeout to 20h to start with sound reasonable? | 16:13:51 |
emily | might make sense to do 48 and then scale down based on the actual time | 16:19:08 |
emily | to avoid spending 20 hours on a build that times out and gets thrown away | 16:19:16 |
emily | (I am not on the infra team, don't trust anything I say) | 16:19:34 |
Vladimír Čunát | I believe it's fine to put an unnecessarily big value in there. It's just a single package. I see the main purpose to limit some accidents where resources would be spent continually without bringing value. | 16:23:17 |
Vladimír Čunát | But honestly, doing so much work in a single derivation is rather risky. Generally it's better to split it up. | 16:24:19 |
Vladimír Čunát | For example, sometimes we need to restart the queue runner, i.e. all builds in progress get scrapped. | 16:24:57 |
Vladimír Čunát | We even had periods where it crashed often (same effect). | 16:25:16 |
Lun | Haven't figured out a way to split it up yet that'll be easy to maintain | 16:26:25 |
Vladimír Čunát | And I have some concerns about increasing latency of channels, but maybe that will turn out negligible. | 16:27:38 |
Vladimír Čunát | * And I have some concerns about increasing latency of channel updates, but maybe that will turn out negligible. | 16:27:48 |
Vladimír Čunát | As it is now, everyone will be waiting for this huge thing to finish. | 16:28:23 |
Vladimír Čunát | * As it is designed now, everyone will be waiting for this huge thing to finish. | 16:29:11 |
emily | so… has hydraPlatforms = [ ]; been considered? | 16:30:05 |
emily | how important is the composable_kernel thing? | 16:30:07 |