| 23 Oct 2021 |
K900 | In reply to @janne.hess:helsinki-systems.de Here you go: https://github.com/NixOS/nixpkgs/pull/142560 Ofborg is still stuck on that | 16:38:15 |
K900 | Maybe we should just merge? | 16:38:24 |
K900 | We know x86-64 passes on ofborg | 16:38:33 |
K900 | And I've looped it for a bit on my Pi4 as well | 16:38:42 |
Janne Heß | I can also separate out the fix for the thread cleanup from the execute() fix since only the execute() fix seems to be debated | 16:39:28 |
Janne Heß | execute() would still be flakey but at least there would be any chance for checks to finish | 16:40:14 |
Janne Heß | * execute() would still be flakey but at least there would be any chance for tests to finish | 16:41:04 |
Janne Heß | Done, the new PR should just unblock the channel and not refactor the execute function which was the only part people had complaints with | 16:54:31 |
K900 | Hopefully that helps | 16:55:09 |
K900 | I can try a better execute design tomorrow morning | 16:55:33 |
Janne Heß | I really like the approach with two commands where we don't have to do that hack separator stuff | 17:14:54 |
K900 | There's a small problem with that | 17:57:29 |
K900 | It's all running on the same socket | 17:57:42 |
K900 | So we can't know when a command's output ends without that | 17:57:54 |
K900 | I had an ever worse idea | 17:58:03 |
K900 | It involves abusing the shell promot | 17:58:10 |
K900 | * It involves abusing the shell prompt | 17:58:14 |
| 24 Oct 2021 |
| vk3wtf joined the room. | 08:15:22 |
Janne Heß | Redacted or Malformed Event | 13:21:30 |
| tollb1 joined the room. | 15:21:43 |
K900 | Janne Heß: https://github.com/NixOS/nixpkgs/pull/142675 is good to merge | 16:19:27 |
K900 | You have merge permissions, right? | 16:19:32 |
Janne Heß | In reply to @k900:0upti.me Janne Heß: https://github.com/NixOS/nixpkgs/pull/142675 is good to merge Maybe tell that to someone who has merge permissions :P | 16:20:15 |
K900 | Oh | 16:20:22 |
K900 | Welp | 16:20:24 |
K900 | https://hydra.nixos.org/build/156582910 | 19:48:51 |
K900 | You love to see it | 19:48:54 |
K900 | (also sorry for breaking tests for 4 days!) | 19:54:37 |
K900 | Also Janne Heß I kinda like the base64 idea | 19:57:28 |
K900 | It sounds absolutely horrible but I do kinda like it | 19:57:34 |