| 19 Oct 2021 |
K900 | Oh no | 13:33:16 |
K900 | I've looked at how execute is implemented | 13:33:23 |
Janne Heß | I did that too and then went on doing anything to unsee that | 13:34:03 |
K900 | i will not attempt to refactor the nixos test infra i will not attempt to refactor the nixos test infra i will not attempt to | 13:34:36 |
Janne Heß | I have also said that about switch-to-configuration when I was younger… it was a lot of pain but it paid off. So go for it 🙃 | 13:36:20 |
nf | In reply to @k900:0upti.me I've looked at how execute is implemented seems like it will fail to detect the magic string if it's split across chunks | 16:53:23 |
nf | that could cause things to hang that weren't supposed to | 16:53:39 |
K900 | Or if the program ever outputs the magic string | 16:54:15 |
K900 | Even by accident | 16:54:24 |
nf | yeah | 16:54:34 |
nf | though that seems less likely | 16:54:58 |
| 20 Oct 2021 |
Domen Kožar | Threading code in python test driver is iffy | 11:49:58 |
hexa | The atexit handler together with the threading seems problematic | 16:39:01 |
K900 | It's fine actually | 16:41:20 |
K900 | atexit handlers run before threads are destroyed | 16:41:37 |
K900 | (which is how threading cleans up after itself, among other things) | 16:41:44 |
K900 | https://hydra.nixos.org/build/156403450/nixlog/298 it's broken again :( | 18:24:24 |
hexa |
Fatal Python error: _enter_buffered_busy: could not acquire lock for <_io.BufferedWriter name='<stderr>'> at interpreter shutdown, possibly due to daemon threads
| 18:37:59 |
hexa | logging thread likely wants to print, but the writer is closed due to thread shutdown | 18:38:17 |
hexa | maybe the last commit that touched that bit should be reverted | 18:38:36 |
hexa | failing tests that don't relate to the actual tests are annoying | 18:38:45 |
K900 | I have a PR that seemingly fixes it | 18:40:29 |
K900 | https://github.com/NixOS/nixpkgs/pull/142207 | 18:41:04 |
Janne Heß | can anyone restart the latest eval of the unstable-small jobsets? | 18:56:06 |
Janne Heß | that's just the flakey test runner that K900 just fixed | 18:56:21 |
Janne Heß | * can anyone with enough permissions restart the latest eval of the unstable-small jobsets? | 18:56:33 |
K900 | Can someone merge my PR before we restart anything? | 18:56:59 |
K900 | Assuming everyone is OK with the changes | 18:57:07 |
Janne Heß | eval takes time anyway | 18:57:10 |
Janne Heß | This eval: https://hydra.nixos.org/eval/1714819 | 18:57:15 |