| 9 Jan 2025 |
|  @feichtmeier:matrix.org changed their profile picture. | 00:08:30 |
| @feichtmeier:matrix.org changed their profile picture. | 00:20:37 |
 João Moreira | how can I move, haskell.lib.compose.justStaticExecutables, haskell.packages.ghc910 etc from all-packages.nix to package.nix so that nixpkgs-vet job succesffully passes (i.e. fits pkgs/by-name)? I tried finding examples on nixpkgs, but they don't seem right / too complex for my derivation.
How it is now:
pkgs/top-level/all-packages.nix
# Check kind-lang.cabal. GHC2024 >= ghc910.
kind-lang = haskell.lib.compose.justStaticExecutables (haskell.packages.ghc910.callPackage ../by-name/ki/kind-lang/package.nix {
haskellPackages = haskell.packages.ghc910;
});
nixpkgs-vet error
- Because pkgs/by-name/ki/kind-lang exists, the attribute `pkgs.kind-lang` must be defined like
kind-lang = callPackage ./../by-name/ki/kind-lang/package.nix { /* ... */ };
However, in this PR, it isn't defined that way. See the definition in pkgs/top-level/all-packages.nix:6458
kind-lang = haskell.lib.compose.justStaticExecutables (haskell.packages.ghc910.callPackage ../by-name/ki/kind-lang/package.nix {
haskellPackages = haskell.packages.ghc910;
});
This PR introduces the problems listed above. Please fix them before merging, otherwise the base branch would break.
To run locally: ./ci/nixpkgs-vet.sh master https://github.com/NixOS/nixpkgs.git
If you're having trouble, ping @NixOS/nixpkgs-vet
Error: Process completed with exit code 1.
pr https://github.com/NixOS/nixpkgs/pull/371934
| 11:56:35 |
 chreekat | João Moreira: by-name/pr/pretty-simple/package.nix might be one place to find inspiration | 12:15:58 |
| chreekat | I grepped for 'haskellPackages' in by-name and tried to find something similar | 12:16:11 |
 linj | In reply to @joaomoreira:matrix.org
how can I move, haskell.lib.compose.justStaticExecutables, haskell.packages.ghc910 etc from all-packages.nix to package.nix so that nixpkgs-vet job succesffully passes (i.e. fits pkgs/by-name)? I tried finding examples on nixpkgs, but they don't seem right / too complex for my derivation.
How it is now:
pkgs/top-level/all-packages.nix
# Check kind-lang.cabal. GHC2024 >= ghc910.
kind-lang = haskell.lib.compose.justStaticExecutables (haskell.packages.ghc910.callPackage ../by-name/ki/kind-lang/package.nix {
haskellPackages = haskell.packages.ghc910;
});
nixpkgs-vet error
- Because pkgs/by-name/ki/kind-lang exists, the attribute `pkgs.kind-lang` must be defined like
kind-lang = callPackage ./../by-name/ki/kind-lang/package.nix { /* ... */ };
However, in this PR, it isn't defined that way. See the definition in pkgs/top-level/all-packages.nix:6458
kind-lang = haskell.lib.compose.justStaticExecutables (haskell.packages.ghc910.callPackage ../by-name/ki/kind-lang/package.nix {
haskellPackages = haskell.packages.ghc910;
});
This PR introduces the problems listed above. Please fix them before merging, otherwise the base branch would break.
To run locally: ./ci/nixpkgs-vet.sh master https://github.com/NixOS/nixpkgs.git
If you're having trouble, ping @NixOS/nixpkgs-vet
Error: Process completed with exit code 1.
pr https://github.com/NixOS/nixpkgs/pull/371934
another example is nixfmt-rfc-style | 12:19:09 |
| @feichtmeier:matrix.org changed their profile picture. | 16:23:16 |
| @feichtmeier:matrix.org changed their profile picture. | 18:20:21 |
 alexfmpe | I'd like to fix eval/build for a few packages in ghc912, but am a bit confused by the current state
the haskell-updates -> staging branch has conflicts on a bunch of configuration-foo.nix files? | 19:08:06 |
| alexfmpe | I need to remove at least half a dozen overrides on configuration-ghc910.nix to fix eval
(also not sure why these are triggered by ghc912 packages, maybe some side effect of building 9.12 with 9.10) | 19:09:24 |
| alexfmpe | * I need to remove at least half a dozen (no longer valid due to stackage containing latest version) overrides on configuration-ghc910.nix to fix eval
(also not sure why these are triggered by ghc912 packages, maybe some side effect of building 9.12 with 9.10) | 19:09:54 |
| alexfmpe | * I need to remove at least half a dozen (no longer valid due to LTS 23 containing latest version) overrides on configuration-ghc910.nix to fix eval
(also not sure why these are triggered by ghc912 packages, maybe some side effect of building 9.12 with 9.10) | 19:10:02 |
| @feichtmeier:matrix.org changed their profile picture. | 19:49:56 |
| @feichtmeier:matrix.org changed their profile picture. | 20:03:27 |
| @feichtmeier:matrix.org changed their profile picture. | 20:04:22 |
| @feichtmeier:matrix.org changed their profile picture. | 20:04:50 |
| @feichtmeier:matrix.org changed their profile picture. | 20:07:23 |
| @feichtmeier:matrix.org left the room. | 20:49:10 |
| 10 Jan 2025 |
 sterni (he/him) | alexfmpe: https://github.com/NixOS/nixpkgs/pull/372229 for 9.10 (yes 9.12 ist built using 9.10) | 09:28:59 |
| sterni (he/him) | as to the merge conflicts, they are not real. haskell-updates is practically fast forward compared to staging, but it doesn’t contain the merge commit haskell-updates -> staging so git can’t infer that there’s no problem in practice | 09:30:22 |
| sterni (he/him) | the conflicts should all be solvable by the automatic strategy when we merge | 09:30:50 |
| sterni (he/him) | or go away when staging-next including the last merge commit propagate to master an back to our branch | 09:31:29 |
| sterni (he/him) | I still need to document the new setup which would explain it | 09:31:42 |
| sterni (he/him) | but haven’t managed to solve alls issues with it yet :( | 09:32:06 |
| alexfmpe | Ok so I won't make your life harder if I PR to that PR with changes to configjration-foo files? | 12:02:26 |
| alexfmpe | * Ok so I won't make your life harder if I PR to that PR with changes to configuration-foo files? | 12:02:36 |
| alexfmpe | Or rather | 12:03:10 |
| alexfmpe | By branching off your remove-attributed, then targeting haskell-updates with other changes to configuration-foo | 12:03:50 |
| sterni (he/him) | if you pick my commit and pr stuff with that included we can just merge that yeah | 14:29:59 |
| alexfmpe | okok | 16:06:35 |
