| 28 Aug 2025 |
Thibaut | it's not enough | 23:15:42 |
| 29 Aug 2025 |
| @luna-null:matrix.org left the room. | 02:40:19 |
| @zeorin:matrix.org left the room. | 07:03:56 |
sterni (he/him) | downgrading data-default is not a good option anyways since it is likely to cause issues elsewhere | 10:41:45 |
sterni (he/him) | We can do the bound adjustment via patches/overrides as well, we don't need to wait for upstream | 10:43:00 |
Uraraka ~ Ochaco | Ughh I've had terrible trouble with data-default-class vs data-default. Had to update bounds for another package because of the incompatible update. | 10:58:40 |
Thibaut | despite the patches, jailbreaks, I end up with this issue:
> src/Dhall/LSP/Util.hs:16:16: error: [GHC-87543]
> Ambiguous occurrence ‘show’.
> It could refer to
> either ‘Prelude.show’,
> imported from ‘Prelude’ at src/Dhall/LSP/Util.hs:3:8-21
> (and originally defined in ‘ghc-internal-9.1002.0:GHC.Internal.Show’),
> or ‘Data.Text.show’,
> imported from ‘Data.Text’ at src/Dhall/LSP/Util.hs:11:1-16.
> |
> 16 | tshow = pack . show
is it fine if I patch it as tshow = pack . Prelude.show?
| 11:15:33 |
Artem | In reply to @thibaut:fsl.sh
despite the patches, jailbreaks, I end up with this issue:
> src/Dhall/LSP/Util.hs:16:16: error: [GHC-87543]
> Ambiguous occurrence ‘show’.
> It could refer to
> either ‘Prelude.show’,
> imported from ‘Prelude’ at src/Dhall/LSP/Util.hs:3:8-21
> (and originally defined in ‘ghc-internal-9.1002.0:GHC.Internal.Show’),
> or ‘Data.Text.show’,
> imported from ‘Data.Text’ at src/Dhall/LSP/Util.hs:11:1-16.
> |
> 16 | tshow = pack . show
is it fine if I patch it as tshow = pack . Prelude.show?
This is a problem with many packages :-( | 11:22:57 |
sterni (he/him) | The best solution is probably to submit a proper patch for this to upstream, using CPP. You'd want to use Text.show for text >= 2.1.2 and keep the current code for Text < 2.1.2. | 11:32:49 |
sterni (he/him) | Prelude.show would work, I guess, though it is a bit silly to implement tshow yourself if Data.Text exposes it now | 11:33:59 |
Artem | I don't think you need any CPP: with proper qualifications it should be perfectly backwards compatible. | 13:19:25 |
sterni (he/him) | sure | 16:04:05 |
sterni (he/him) | * ~~sure~~ | 16:04:30 |
sterni (he/him) | * sure | 16:04:35 |
| magic_rb changed their profile picture. | 19:30:45 |