| 22 May 2021 |
sterni (he/him) | right indeed | 21:05:06 |
sterni (he/him) | just got to find a clean way to track the preferred-versions file while also making it editable | 21:05:49 |
maralorn | sterni: I don‘t think we need it editable. We can always override single versions via the yaml config. | 21:06:41 |
maralorn | Huh, now that I think about it … | 21:07:54 |
maralorn | I don‘t even think we need to track the latest hackage snapshot in nixpkgs. We only need to track which snapshot we use for preferred_versions. | 21:08:38 |
maralorn | Would make the update script impure though | 21:09:39 |
sterni (he/him) | but don't we want to keep preferred_versions and bump a single packae | 21:09:42 |
sterni (he/him) | * but don't we want to keep preferred_versions and bump a single package? | 21:09:47 |
maralorn | But I think only theoretically. | 21:09:57 |
maralorn | sterni: Yes, what we would do is this a) use the pinned snapshot for preferred_versions b) use a freshly pulled snapshot from hackage for running hackage2nix c) for packages where we want the version to be newer than the preferred_version we pin the package in the yaml file. | 21:11:47 |
maralorn | We already do a). | 21:11:56 |
maralorn | But b) is necessary for c) to work, because otherwise hackage2nix would possible not know about the newer package version. | 21:12:19 |
sterni (he/him) | ah yeah right that works | 21:12:30 |
maralorn | Two downsides: 1) updating might get a bit more expensive because it always looks for a fresh snapshot. 2) callHackage can only use versions in the pinned snapshot. | 21:15:14 |
maralorn | But 2) is not worse than what we do now. | 21:15:38 |
sterni (he/him) | it's the same as we do now? | 21:20:40 |
maralorn | Yes | 21:20:57 |
maralorn | I just was briefly considering pinning 2 hackage-versions one for the preferred versions and one for generating + callHackage. Then it would be absolutely frictionless to update the one for callHackage, e.g. on stable regularly. | 21:22:19 |
| 23 May 2021 |
| cleverca22 joined the room. | 01:42:17 |
cdepillabout | Looks like the branch-off has happened! | 02:54:30 |
| codygman joined the room. | 03:12:04 |
joe (he/him) | my patch made it. Thanks for the speed-merging :D | 03:29:45 |
sterni (he/him) | let's just hope upstream hnix doesn't take up an issue with it the next few days | 03:30:13 |
sterni (he/him) | but looked like a genuine bug to me as well | 03:30:27 |
joe (he/him) | It's already on Hackage! | 03:30:52 |
sterni (he/him) | ah, awesome :) should've subscribed to the PR's notifications then | 03:31:10 |
joe (he/him) | Also: "I am upstream hnix" (in part of course) | 03:31:20 |
sterni (he/him) | I see, wasn't aware. | 03:51:17 |
joe (he/him) | is peti still doing things, I notice he's no longer a suggested review | 04:47:53 |
joe (he/him) | * is peti still doing things? I notice he's no longer a suggested reviewer | 04:48:01 |