| 6 Aug 2025 |
 cleverca22 | it fetches, but its the same botched fetch | 04:09:56 |
| cleverca22 | cant seem to craft a valid url that clones it correctly | 04:11:14 |
 dramforever | git+https://github.com/grumpycoders/pcsx-redux.git?ref=refs/heads/main i'd say | 04:15:33 |
| dramforever | and it's imo arguable which one is correct | 04:16:00 |
| cleverca22 | [clever@amd-nixos:~/apps/vali/pcsx-redux]$ rm -rf ~/.cache/nix
[clever@amd-nixos:~/apps/vali/pcsx-redux]$ nix build 'git+https://github.com/grumpycoders/pcsx-redux.git?ref=refs/heads/main&rev=1b0cbe5e4a535def2e3e3279551e6665cdc102ae'
error: builder for '/nix/store/5v3fjh1s5pdr385as5fjir17jvwy06xx-pcsx-redux-0.99test.drv' failed with exit code 2;
last 25 log lines:
> | ^~~~~~~~~~
> compilation terminated.
> In file included from patches/remove_ChgclrPAD_2.c:30:
> /build/source/src/mips/openbios/sio0/pad.h:30:10: fatal error: stdlib.h: No such file or directory
> 30 | #include <stdlib.h>
> | ^~~~~~~~~~
| 04:16:39 |
| cleverca22 | also fails | 04:16:41 |
| dramforever | ... huh | 04:17:39 |
| dramforever | so it's only git+file that eats submodules | 04:18:10 |
| cleverca22 | and the question becomes, which one is "right"? | 04:20:35 |
| cleverca22 | i guess now its time to pop open a ticket on github? | 04:20:57 |
| dramforever | git archive generates empty directory for submodule | 04:21:29 |
| dramforever | so i'm starting to think empty directory is "correct" | 04:21:41 |
| cleverca22 | so fixing nix, would remove the one case where it works, and then pcsx-redux definitely needs a PR to fix it | 04:22:18 |
| dramforever | yes | 04:24:36 |
| dramforever | even though i guess it would be slightly weird now | 04:24:56 |
| dramforever | because until nix gets fixed you kinda need to handle both cases | 04:25:15 |
| cleverca22 | you just need to rmdir, and handle if its already missing | 04:25:33 |
| cleverca22 | and then copy the submodule into place | 04:25:37 |
| cleverca22 | and all of this mess, is only because flakes strip submodules! | 04:25:59 |
| cleverca22 | https://github.com/grumpycoders/pcsx-redux/blob/main/pcsx-redux.nix#L39-L117 | 04:26:45 |
| cleverca22 | this whole mess of code, is there to recreate the submodules | 04:26:55 |
| dramforever | probably add -T to cp? | 04:27:32 |
| dramforever | well you can get flakes to do submodules | 04:28:15 |
| cleverca22 | ive tried before, and it doesnt actually do it for self | 04:28:36 |
| dramforever | but you have to use git+something and then ?submodules=1 | 04:28:36 |
| dramforever | like .?submodules=1 | 04:28:43 |
| cleverca22 | for an input you can do it
but for self, you cant | 04:28:47 |
| dramforever | you can't do it by default | 04:29:09 |
| cleverca22 | and that just complicates matters, now the user cant just nix build .# like every other project | 04:29:14 |
| dramforever | yes | 04:29:24 |
