| 12 Sep 2022 |
 k0kada (he/him) | I will probably not review what you did until you push it | 20:10:38 |
| k0kada (he/him) | And review means, look at any other comments in the PR | 20:10:50 |
 ckie (they/them; limited keyboard usage, voice preferred) | from my context i'm waiting for your whole kokada-mon review cycle to be over before i go and look at everything | 20:11:29 |
| k0kada (he/him) | In reply to @ckie:ckie.dev
generally i like day to day things being async so i can do things at my own pace I also like to do things async, but I hate to review hundreds of lines of text/code every time I need to do it | 20:11:47 |
| ckie (they/them; limited keyboard usage, voice preferred) | ah! | 20:11:56 |
| k0kada (he/him) | I much prefer to review just a small amount of code | 20:11:56 |
| ckie (they/them; limited keyboard usage, voice preferred) | opposite here | 20:12:02 |
| ckie (they/them; limited keyboard usage, voice preferred) | i don't remember my review comments at all the next time i do | 20:12:45 |
| ckie (they/them; limited keyboard usage, voice preferred) | every cycle i first look at everything again and write new comments if they're missing, then i go check whats up with my old comments | 20:13:08 |
 ribosomerocker | In reply to@k0kada:matrix.org
Anyway, we will probably enter in an impasse right now mon_aaraj :P i just pushed 👍️ | 20:13:58 |
| ckie (they/them; limited keyboard usage, voice preferred) | nice isolated commits are nice so the diff is sorted by subject though | 20:14:06 |
| k0kada (he/him) | Well, really didn't like how you phrased a few things, but whatever | 20:17:04 |
| k0kada (he/him) | I am not a native English speaker, so maybe this sounds more natural | 20:17:16 |
| ribosomerocker | In reply to@k0kada:matrix.org
Well, really didn't like how you phrased a few things, but whatever like what? i'd love to get your criticism on some of them | 20:36:43 |
| k0kada (he/him) | https://github.com/nix-community/nix-doom-emacs/pull/266/files#diff-0b5ca119d2be595aa307d34512d9679e49186307ef94201e4b3dfa079aa89938R17 | 20:37:13 |
| k0kada (he/him) | https://github.com/nix-community/nix-doom-emacs/pull/266/files#diff-0b5ca119d2be595aa307d34512d9679e49186307ef94201e4b3dfa079aa89938R3 | 20:37:34 |
| k0kada (he/him) | For the second one what do you mean "to have to debug things"? I think the way I suggested was more clear | 20:38:05 |
| k0kada (he/him) | The first one just looks strange for some reason | 20:38:13 |
| ribosomerocker | In reply to@k0kada:matrix.org
For the second one what do you mean "to have to debug things"? I think the way I suggested was more clear well, by "users should expect to have to debug things,", its just trying to tell users what they should expect before using NDE | 20:38:53 |
| k0kada (he/him) | https://github.com/nix-community/nix-doom-emacs/pull/266/files#diff-0b5ca119d2be595aa307d34512d9679e49186307ef94201e4b3dfa079aa89938R13
I put consequences there for a reason | 20:38:56 |
| k0kada (he/him) | Instead of "limitations" | 20:39:17 |
| ribosomerocker | ah, yeah, i paraphrased that one because "consequences" sounded way more serious than what the limitations were, i'll change that back if you want | 20:39:43 |
| k0kada (he/him) | In reply to @mon:tchncs.de
well, by "users should expect to have to debug things,", its just trying to tell users what they should expect before using NDE Don't know, I still thing the way I suggested looked better | 20:40:21 |
| k0kada (he/him) |
and has a fairly amount of experience debugging issues.
| 20:40:29 |
| k0kada (he/him) | But like I said, I am not a native English speaker, so maybe all your changes "sounds" better | 20:41:19 |
| k0kada (he/him) | In reply to @mon:tchncs.de
ah, yeah, i paraphrased that one because "consequences" sounded way more serious than what the limitations were, i'll change that back if you want I mean, it is not necessary a limitation per see (some things are), but more understanding that nix-straight.el means you're not interacting with straight.el itself (at least not directly) | 20:42:04 |
| k0kada (he/him) | So "consequences" for me | 20:42:09 |
| k0kada (he/him) | But really, no need to undo all things | 20:43:59 |
| k0kada (he/him) | Maybe you're right :P | 20:44:13 |
| ribosomerocker | In reply to@k0kada:matrix.org
Don't know, I still thing the way I suggested looked better
Nix-Doom-Emacs (also commonly referred to as NDE in chatrooms) is a project with lots of moving pieces and hacks. Users are expected to know their way around Nix and Emacs (also Emacs Lisp) before using this project. You'll probably have to debug your way around problems pretty frequently.
does this sound better? | 20:44:19 |
