| 12 Sep 2022 |
 ribosomerocker | In reply to @ckie:ckie.dev
mon_aaraj, k0kada : taking the lock on #266 what do you mean? taking a look? | 19:56:13 |
| ribosomerocker | i have a bunch of changes to fix the reviews i havent commited yet, since im waiting for k0kada: https://github.com/nix-community/nix-doom-emacs/pull/267#discussion_r967863908 | 19:57:04 |
 k0kada (he/him) | In reply to @k0kada:matrix.org
Well, I don't think it is strawman. I actually fixed one issue in NDE because of the nix tools :P Also, eventually I want to put NDE in the nix index, and I am almost sure that you need to not have your nix flake show to fail randomly if you want it in there | 19:57:26 |
| k0kada (he/him) | In reply to @mon:tchncs.de
i have a bunch of changes to fix the reviews i havent commited yet, since im waiting for k0kada: https://github.com/nix-community/nix-doom-emacs/pull/267#discussion_r967863908 Well, ckie (they/them) gave the greenlight. Just not going to merge today | 19:58:20 |
| ribosomerocker | i dont mean the flake re-structure | 19:58:55 |
 ckie (they/them) | worth noting it's a conditional green light | 19:58:56 |
| ckie (they/them) | blocked by docs | 19:59:06 |
| ribosomerocker | i mean an example for a user's config flake.nix if they want to use nix-doom-emacs standalone | 19:59:21 |
| ribosomerocker | you were talking about something like nix-darwin or NixOS (without home-manager) i believe | 19:59:47 |
| k0kada (he/him) | In reply to @mon:tchncs.de
i mean an example for a user's config flake.nix if they want to use nix-doom-emacs standalone I think you linked the wrong comment them? | 20:00:04 |
| ckie (they/them) | #267 and #268 should've been one PR | 20:00:08 |
| ckie (they/them) | with some of the misc stuff in #267 in its own PR | 20:00:17 |
| ribosomerocker | oh wait, ted, i think i linked the wrong discussion haha | 20:00:20 |
| ribosomerocker | * oh wait, yeah, i think i linked the wrong discussion haha | 20:00:33 |
| ckie (they/them) | so assume they're going to be merged at the same time | 20:00:35 |
| ckie (they/them) | * #267 and #266 should've been one PR | 20:01:18 |
| ribosomerocker | yep, got it | 20:02:08 |
| ribosomerocker | 
Download Screenshot_2022-09-12-23-02-33-44_3aea4af51f236e4932235fdada7d1643.jpg | 20:02:53 |
| ribosomerocker | k0kada: GitHub REALLY doesnt want me to grab the link to this discussion apparently | 20:03:09 |
| k0kada (he/him) | In reply to @mon:tchncs.de
sent an image. Sure, I know | 20:03:19 |
| ribosomerocker | so i had to send a pic instead :P | 20:03:23 |
| k0kada (he/him) | Still, there is so many other things to fix | 20:03:31 |
| k0kada (he/him) | I am waiting at least for a few of the comments to be fixed first | 20:03:41 |
| ribosomerocker | they're already fixed on local, im planning to push everything to fix all your reviews at once | 20:04:01 |
| ribosomerocker | thats the only review that i havent fixed yet and im not sure how to fix it | 20:04:36 |
| k0kada (he/him) | In reply to @mon:tchncs.de
they're already fixed on local, im planning to push everything to fix all your reviews at once I know this depends on the person, but I hate this | 20:06:05 |
| ckie (they/them) | hah, i do that too | 20:06:45 |
| k0kada (he/him) | Instead of being incremental changes, it then becomes a huge amount of changes to review | 20:06:54 |
| ckie (they/them) | aha! | 20:07:07 |
| ckie (they/them) | yeah i suppose (?:me|mon)'s style assumes infrequent contact | 20:07:48 |
