24 Sep 2021 |
zrsk | * yeah | 19:58:42 |
zrsk | However for a similar task I think this would turn out useful. | 19:59:08 |
zrsk | Probabily using this and jq it could be a one line | 19:59:58 |
zrsk | David Arnold (blaggacao): However thank you again! Sorry for the many questions and the bad english | 20:00:49 |
David Arnold (blaggacao) | I mean why wouldn't you test all the architectures that you declared as supported in an environment where you can do that. | 20:01:47 |
David Arnold (blaggacao) | Maybe Github is not the right tool. But with a little hackery, it might still be useful. | 20:02:15 |
David Arnold (blaggacao) | I don't mean to push back, just set the context. 😆😁 | 20:02:47 |
Pacman99 | I got in a PR to do the externalModules -> modules rename. I'm not very familiar with git submodules, what is the process to update devos with API changes?. I added a commit to the submodule in digga, but is there some way to connect that to a PR in devos? | 21:20:37 |
Pacman99 | Also just saw the build error, I'll get to that soon | 21:24:28 |
Pacman99 | Ohh well my question above is related to the build error I think | 21:24:53 |
David Arnold (blaggacao) | You can push that commit directly to a branch on devos, then do the PR there. | 21:25:42 |
Pacman99 | Can I do that within the submodule(as in within examples/downstream) or should I do it in a separate clone of devos? | 21:26:41 |
David Arnold (blaggacao) | Yes, the submodule is like another git worktree. | 21:28:16 |
Pacman99 | ok got it, https://github.com/divnix/devos/pull/378 | 21:30:37 |
Pacman99 | Do we merge both PRs together, assuming we have approvals for everything | 21:32:26 |
26 Sep 2021 |
David Arnold (blaggacao) | In a way merging digga first is ok, since devos 's lockfile still points to the old version. | 16:39:09 |
27 Sep 2021 |
Pacman99 | The problem is I would like to merge the digga PR with bors to ensure all checks pass(I only ran through some on my local machine), and I don't know how to do that without merging the devos one first | 00:46:44 |
ultranix | In reply to @blaggacao:matrix.org I don't understand the gist of the "emacs "-issue, though. Can you boil it down? input to a flake is called emacs, also a user profile directory (in suites) is called emacs. it wont build | 01:13:12 |
Pacman99 | You can do profiles.suites | 01:14:20 |
Pacman99 | * You can do profiles.emacs | 01:14:51 |
ultranix | good to know, that works | 01:17:51 |
| NikolayTach joined the room. | 06:50:02 |
| NikolayTach set a profile picture. | 06:50:59 |
NikolayTach | Hello | 06:51:37 |
NikolayTach | Redacted or Malformed Event | 06:57:50 |
| Narice set a profile picture. | 10:09:59 |
@timdeh:matrix.org | hello and welcome | 17:14:50 |
David Arnold (blaggacao) | In reply to @ultranix:matrix.org input to a flake is called emacs, also a user profile directory (in suites) is called emacs. it wont build This looks like a good old variable shadowing, not something that I can relate to something that digga would do, though. | 17:27:39 |
David Arnold (blaggacao) | In reply to @pachumicchu:myrdd.info The problem is I would like to merge the digga PR with bors to ensure all checks pass(I only ran through some on my local machine), and I don't know how to do that without merging the devos one first That's not necessary, the submodule just checks out the respective commit. If that commit is already on GitHub's server then that's all it takes. | 17:36:23 |
David Arnold (blaggacao) | Jut make sure you got the right submodule commit checked in on the commit. | 17:37:07 |