!VRULIdgoKmKPzJZzjj:nixos.org

Nix Hackers

848 Members
For people hacking on the Nix package manager itself183 Servers

Load older messages


SenderMessageTime
19 Sep 2025
@fzakaria:one.ems.hostfzakariawhy does it need whoelStoreView16:15:25
@Ericson2314:matrix.orgJohn Ericsonso I can't tell how things are being invoked / ultimately from what16:15:27
@Ericson2314:matrix.orgJohn Ericson for get getFSAccessor method 16:15:40
@Ericson2314:matrix.orgJohn Ericsonmaybe that should be changed so you can only ask the store for individual object source accessors16:15:55
@Ericson2314:matrix.orgJohn Ericsonbut that is a separate refactor16:15:59
@Ericson2314:matrix.orgJohn Ericsonand that also may not work16:16:03
@fzakaria:one.ems.hostfzakariaoh you merge it16:16:15
@fzakaria:one.ems.hostfzakariaon every call to addtoStore16:16:32
@Ericson2314:matrix.orgJohn Ericson yeah I am using shared pointers, but conceptually the std::map<StorePath, ....> owns the data 16:16:39
@fzakaria:one.ems.hostfzakariawhy is it only addToStoreFromDump and not addToStore16:16:45
@Ericson2314:matrix.orgJohn Ericsonand the view is just splatting those together16:16:46
@fzakaria:one.ems.hostfzakariaaddToStore is unsupported16:16:57
@Ericson2314:matrix.orgJohn Ericsonsimply because I didn't do the other methods yet16:16:58
@fzakaria:one.ems.hostfzakariaoh16:17:06
@fzakaria:one.ems.hostfzakariaok16:17:07
@fzakaria:one.ems.hostfzakariasorry16:17:08
@Ericson2314:matrix.orgJohn Ericson I think we need Sergei Zimmerman (xokdvium)'s help to fix the type error 😅 but after that, you are welcome to do the rest 16:17:28
@fzakaria:one.ems.hostfzakaria

I think i see what you mean:

ref<MemorySourceAccessor> wholeStoreView = make_ref<MemorySourceAccessor>();

That is probably a pattern (Delegating MemorySource Accessor or Composite accessor)

16:18:05
@Ericson2314:matrix.orgJohn EricsonI think that line is fine?16:18:20
@Ericson2314:matrix.orgJohn EricsonI am not sure though16:18:23
@Ericson2314:matrix.orgJohn Ericsonwill try changing it16:18:24
@fzakaria:one.ems.hostfzakariai meant having 1 accessor but have it hide away the fact it's multiple; but maybe that doesn't matter once you do whatever subsequent refactor you meant16:19:00
@Ericson2314:matrix.orgJohn Ericsonoh ok16:19:21
@fzakaria:one.ems.hostfzakariai might epxlore after your work; the sqlite variant.... it's got a worm in my brain about it. I like that sqlite can do in-memory or also persist to a file.16:19:50
@Ericson2314:matrix.orgJohn Ericsondo you think that can be deduplicated with local store?16:24:57
@Ericson2314:matrix.orgJohn Ericsonit sounds quite complicated to me16:25:04
@Ericson2314:matrix.orgJohn EricsonI like this because it is very much a companion to the store section of the manual16:25:16
@Ericson2314:matrix.orgJohn Ericsonit implements the spec in the simplest/purest possible way16:25:23
@mkg20001:mkg20001.iomkg20001 changed their profile picture.17:22:34
@philiptaron:matrix.orgPhilip Taron (UTC-8)I noticed that no https://nix.dev/manual/nix/2.31 links, like https://nix.dev/manual/nix/2.31/language/builtins, work.23:27:26

Show newer messages


Back to Room ListRoom Version: 6