16 Sep 2025 |
getchoo | ....nevermind
$ ls -d nix-tarball/nix-2.32.0pre20250915_5e17a3f-x86_64-linux/store/*-[nl]ix-*.*.* | head -n 1
nix-tarball/nix-2.32.0pre20250915_5e17a3f-x86_64-linux/store/dkmylx2wyz9i6ycbmr07lpv15mph0d7y-nix-main-2.32.0pre
| 06:37:04 |
Mic92 | getchoo: should we just fix the regex? | 11:22:45 |
Mic92 | by making it more specific | 11:23:01 |
matthewcroughan | Why is it git+file and not git+path | 13:27:26 |
toonn | Extension of the file protocol? | 13:35:23 |
matthewcroughan | but the argument you pass it, is a path, not a file | 14:27:22 |
matthewcroughan | git+file:/home/foo is not a file, but this is necessary | 14:27:35 |
matthewcroughan | it should be git+path:/home/foo | 14:27:49 |
dramforever | git calls it file https://git-scm.com/book/ms/v2/Git-on-the-Server-The-Protocols | 14:32:20 |
dramforever | i think path: is a nix invention... probably | 14:33:06 |
toonn | matthewcroughan: I meant as an extension of the file URI scheme, file:///some/path . | 14:34:48 |
getchoo | In reply to @joerg:thalheim.io by making it more specific that’s what i was thinking
we could also iterate over the glob matches and use the first one that actually has a /bin/nix subpath as well to be a bit safer (since i really doubt the day will come where we have multiple nix binaries in the store during install) | 16:51:32 |
getchoo | * this worked before the component split in 2.29 since there would only be one main nix store path at this point, but now it matches the nix-main store path first, which doesn't have a bin dir or any of the nix binaries | 16:52:24 |
Mic92 | In reply to @getchoo:matrix.org that’s what i was thinking
we could also iterate over the glob matches and use the first one that actually has a /bin/nix subpath as well to be a bit safer (since i really doubt the day will come where we have multiple nix binaries in the store during install) Is this not just scanning the installation tarball rather the entire nix store? | 20:22:46 |
Mic92 | I haven't looked to deep into the code. | 20:23:13 |
getchoo | it is, but the installation tarball now has multiple paths that match nix-* due to the component split | 20:32:59 |
getchoo | so depending on the hashes you get, sometimes one of the components will be matched first and the installer will just blindly append the /bin/nix-store subpath to it and try executing | 20:35:12 |
17 Sep 2025 |
Mic92 | Okay seems like an easy fix than to just check for the path to exist | 07:56:51 |
| adamcstephens joined the room. | 18:01:13 |
18 Sep 2025 |
getchoo | yeah, just was away from home yesterday. finished it up a little bit ago https://github.com/NixOS/experimental-nix-installer/pull/48 | 04:33:15 |
| Julian joined the room. | 10:57:15 |
adamcstephens | Mic92: you mentioned wanting some CI improvements for the installer in order to get it official. I can put in some time to help on this. Do you have a list of things you'd want to see added/fixed? | 13:07:08 |
Mic92 | adamcstephens: https://github.com/NixOS/nix/pull/14002 you can help getchoo to fix the installer tarball | 15:41:32 |
Mic92 | This one: https://github.com/NixOS/experimental-nix-installer/issues/47 | 15:43:01 |
Sergei Zimmerman (xokdvium) | Philip Taron (UTC-8): 2.31.2 is up. Up for a nixpkgs bump? | 17:36:04 |
Philip Taron (UTC-8) | yessir | 17:45:37 |
Philip Taron (UTC-8) | does that include your bindings banaza | 17:45:51 |
Philip Taron (UTC-8) | does that include your bindings banaza | 17:47:31 |
Sergei Zimmerman (xokdvium) | In reply to @philiptaron:matrix.org does that include your bindings banaza That won’t get backported. But hopefully 2.32 will be out next week | 17:49:00 |
Philip Taron (UTC-8) | The update from 2.28 to a newer version is blocked on some regressions Mic mentioned. I'm not tracking that closely. Is 2.32 on track to fix them? | 17:50:15 |