18 Sep 2025 |
maralorn | Fair enough. | 17:58:40 |
maralorn | The true problem with nom is that I just can’t find the time for it. 😄 | 18:00:32 |
Sergei Zimmerman (xokdvium) | As John points out it’d be great to have this type and parser in hnix-store to avoid the need to reinvent the wheel | 18:00:26 |
maralorn | Anyway, this is sliding into offtopic. | 18:00:34 |
Philip Taron (UTC-8) | https://github.com/NixOS/nixpkgs/pull/444079 | 18:01:26 |
Sergei Zimmerman (xokdvium) | In reply to @maralorn:maralorn.de The true problem with nom is that I just can’t find the time for it. 😄 Hopefully Nix code will just get cleaned up enough to either have this directly in nix or expose a more structured and stable endpoint for logs and events that doesn’t require parsing MBs of json | 18:03:36 |
Philip Taron (UTC-8) | OK, I ran tests on Darwin and on Linux. I think we're good for merge of 2.31.2 after a ✅️ @Sergei Zimmerman (xokdvium) | 18:36:14 |
Sergei Zimmerman (xokdvium) | Philip Taron (UTC-8): btw, here's the metrics and the impact from the bindings change: https://hydra.nixos.org/job/nix/master/metrics.nixpkgs/metric/nix-env.qaAggressive.allocations | 20:02:08 |
Philip Taron (UTC-8) | very cool | 20:05:53 |
Philip Taron (UTC-8) | is that powered by pkgs/top-level/metrics.nix ? | 20:06:18 |
Philip Taron (UTC-8) | if so shift your bookmark to https://hydra.nixos.org/job/nix/master/metrics.nixpkgs/metric/nix-env.qa.allocations | 20:06:45 |
Philip Taron (UTC-8) | (qaAggresive and qa had been the same since 2019) | 20:07:21 |
Philip Taron (UTC-8) | https://github.com/NixOS/nixpkgs/pull/442477 | 20:07:37 |
Sergei Zimmerman (xokdvium) | Yeah, it's using a pinned nixpkgs checkout from a62e6edd6d5e1fa0329b8653c801147986f8d446 (23-11) | 20:08:49 |
Sergei Zimmerman (xokdvium) | Yay, finally ASAN https://github.com/NixOS/nix/pull/14016 | 22:41:45 |
19 Sep 2025 |
| adamcstephens left the room. | 02:54:03 |
| adamcstephens joined the room. | 02:58:41 |
getchoo | once https://github.com/NixOS/experimental-nix-installer/pull/48 is merged, we’re either going to need a new release in the experimental installer repo, or actually upload regular artifacts from the ci builds | 07:05:14 |
getchoo | i think the latter would be good to add in any case…but looking at the current workflows, it’s kinda a mess IMO
i was wondering if everyone would be ok with a major refactoring of it all? mainly just making things a proper matrix job instead of having a ton of copy-pasted individual steps and workflows? | 07:06:06 |
getchoo | because honestly it would be easier for me than changing the same step like a dozen times lmao | 07:07:22 |
getchoo | but it’d also probably be better for any eventual merging into the main nix repo, or any other ci changes in the future | 07:07:48 |
getchoo | * once https://github.com/NixOS/experimental-nix-installer/pull/48 is merged, we’re either going to need a new release in the experimental installer repo, or actually upload regular artifacts from the ci builds to use it in nix’s installer tests | 07:08:24 |
Sergei Zimmerman (xokdvium) | In reply to @getchoo:matrix.org i think the latter would be good to add in any case…but looking at the current workflows, it’s kinda a mess IMO
i was wondering if everyone would be ok with a major refactoring of it all? mainly just making things a proper matrix job instead of having a ton of copy-pasted individual steps and workflows? I would love to do this! Since I’m done with ASAN changes I’d love to work making the CI suck less. Would you like to pair up on this? | 07:20:11 |
Sergei Zimmerman (xokdvium) | CI is a total mess and needs a major rework anyway. The matrix is too small, aarch64 Linux is not built and so on. | 07:24:22 |
Sergei Zimmerman (xokdvium) | In reply to @getchoo:matrix.org i think the latter would be good to add in any case…but looking at the current workflows, it’s kinda a mess IMO
i was wondering if everyone would be ok with a major refactoring of it all? mainly just making things a proper matrix job instead of having a ton of copy-pasted individual steps and workflows? Go for it in any case. The tests jobs could use some love.
Also it would be great to run NixOS tests with sanitizers on GHA and hydra. It’s almost wired up and just needs a proper matrix set up | 07:37:05 |
jaen | Any suggestions on that? Want to continue with the rebase this weekend, but had no time to think on how to resolve that. One odd-hand idea I didn't test is that this is being specified in the devshell: https://github.com/NixOS/experimental-nix-installer/blob/main/Cargo.toml#L74 https://github.com/NixOS/experimental-nix-installer/blob/main/flake.nix#L168 so maybe that envvar could be reused in the test? Didn't test that yet and not quite sure what the expectation of this tests is given that this profile does not exist on any of my NixOS machines — are my machines set up incorrectly or is the upstream installer making some weird assumption? Or maybe the test should create a temporary directory with a profile and pass that? Sorry if the answer is obvious, didn't really come across that particular issue before. | 11:58:24 |
John Ericson | fzakaria: https://github.com/NixOS/nix/pull/14023/files OK here is WIP thing | 16:14:15 |
John Ericson | Sergei Zimmerman (xokdvium): ^ this has one of the worst C++ errors I've every seen! | 16:14:29 |
John Ericson | I think my wrapper constructor for the std::variant class is shadowing a built-in constructor | 16:14:51 |
John Ericson | but also the template instation trace in the diagnostic is missing | 16:15:11 |