| 29 Aug 2025 |
 John Ericson | ubsan | 23:41:27 |
 fzakaria | oh you went back to string_view | 23:41:29 |
| John Ericson | Sergei Zimmerman (xokdvium): is loking | 23:41:34 |
| fzakaria | yea that's bad, clangd is giving me the warning | 23:41:39 |
| fzakaria | wait is it... | 23:41:48 |
| fzakaria |
Clang-Tidy: Std::move of the const variable 'path' of the trivially-copyable type 'const std::basic_string_view<char>' has no effect; remove std::move()
| 23:41:51 |
| fzakaria | i get bitten too much by rvalue and string_view... i thought it was such a cool feature | 23:42:35 |
| fzakaria | and now i ignore it | 23:42:38 |
| John Ericson | yeah the std::move can go goes it's trivially coppiable | 23:42:57 |
| fzakaria | i learned about some hack that the compiler does for rvalues that are also created as function variables to make their lifetime expended. | 23:43:01 |
| fzakaria | expanded* | 23:43:13 |
| fzakaria | i see this | 23:43:32 |
| fzakaria |
Clang-Tidy: Std::basic_string_view outlives its value
| 23:43:33 |
| fzakaria |
Clangd: Object backing the pointer 'modifiedUrl' will be destroyed at the end of the full-expression
| 23:43:43 |
| John Ericson | ah yeah | 23:44:04 |
| John Ericson | I only did one of the two path prefix thinggies | 23:44:12 |
| John Ericson | I didn't see the other | 23:44:14 |
| fzakaria | why did you chang eit to push back empty string? | 23:44:50 |
| fzakaria |
path.emplace_back("");
| 23:44:52 |
| fzakaria | (it was pushing back forward slash before) | 23:45:14 |
| John Ericson | give it a pull | 23:48:56 |
| fzakaria | oh i was gonan land them ;P | 23:49:11 |
| John Ericson | oh sorry | 23:49:22 |
| John Ericson | I did that because the initial "" makes an initial / | 23:49:33 |
| John Ericson | I get a test failure now | 23:49:56 |
| John Ericson | but at least local and CI should agree | 23:50:00 |
| fzakaria | from what ? | 23:51:22 |
| fzakaria | i thin kits from the new try | 23:52:39 |
| fzakaria | parseURL actually parses scp like... | 23:52:50 |
| fzakaria | that's why i had the if guard | 23:52:54 |
