29 Aug 2025 |
John Ericson | fzakaria: bugs in master or your PR? | 03:26:43 |
fzakaria | hmm i have to see the difference; it's thorny | 03:28:26 |
fzakaria | like should 2001:db8:0:1 allowed; short-hand ipv6 ? | 03:28:36 |
fzakaria | i saw it was accepted elsewhere but maybe not | 03:29:39 |
fzakaria | i don't get ipv6 shortening; 2001:db8:1::2 is valid but i've seen 2001:db8:0:1 also | 03:33:21 |
fzakaria | just ignore me | 03:34:18 |
fzakaria | k rebased it... I just had some weird merges | 03:45:05 |
fzakaria | so that was the issue; just working late rubs eyes | 03:45:12 |
fzakaria | 🙇 | 03:45:17 |
| kdeuser joined the room. | 17:38:47 |
| magic_rb changed their profile picture. | 19:27:19 |
John Ericson | ahhh i have many builder goal cleanup commits :) | 19:57:13 |
John Ericson | the knot is unravelling fast!@ | 19:57:19 |
John Ericson | * the knot is unravelling fast! | 19:57:21 |
fzakaria | msut be from the merge it's failing | 23:34:34 |
fzakaria | the branch for me also passes. | 23:34:38 |
fzakaria | i'll rebase from master. | 23:34:41 |
fzakaria | hmm rebase also passes. | 23:35:30 |
fzakaria | maybe John Ericson you'll know why... lol | 23:40:25 |
John Ericson | fzakaria: I dunno! | 23:40:50 |
John Ericson | I guess a bad thing with string_view | 23:41:00 |
John Ericson | ubsan | 23:41:27 |
fzakaria | oh you went back to string_view | 23:41:29 |
John Ericson | Sergei Zimmerman (xokdvium): is loking | 23:41:34 |
fzakaria | yea that's bad, clangd is giving me the warning | 23:41:39 |
fzakaria | wait is it... | 23:41:48 |
fzakaria |
Clang-Tidy: Std::move of the const variable 'path' of the trivially-copyable type 'const std::basic_string_view<char>' has no effect; remove std::move()
| 23:41:51 |
fzakaria | i get bitten too much by rvalue and string_view... i thought it was such a cool feature | 23:42:35 |
fzakaria | and now i ignore it | 23:42:38 |
John Ericson | yeah the std::move can go goes it's trivially coppiable | 23:42:57 |