17 Jul 2025 |
Mic92 | * So you mean you only want to scan changed files? Good idea | 13:29:42 |
Mic92 | Than we can enable even more checks. | 13:30:28 |
Sergei Zimmerman (xokdvium) | Yeah, it should be part of clang-tools-extra alongside clang-tidy, but nixpkgs build doesn't seem to have it for some reason. | 13:30:31 |
Sergei Zimmerman (xokdvium) | https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py | 13:31:00 |
fzakaria | Clang-tidy bonanza!? | 17:41:18 |
fzakaria | sweet -- the IWYU is what i'm really after. | 17:41:28 |
fzakaria | Makes navigating the codebase way easier. | 17:41:34 |
fzakaria | i'm going to try and take on another issue from FetchTree tonight and stream again... (I'm picking some easy ones for now) | 17:42:03 |
Alyssa Ross | IWYU is difficult for portable programs like Nix | 19:28:52 |
Alyssa Ross | Often the header something happens to be defined in for your platform isn't the one you should actually be including to be standards conformant and portable | 19:29:09 |
Alyssa Ross | (If it's possible to exclude libc headers rthat would probably help) | 19:30:31 |
18 Jul 2025 |
fzakaria | aren't we solving that with Nix ? | 02:45:02 |
fzakaria | like... we own all the header up until glibc... there's nothing non-portable | 02:45:16 |
emily | Nix runs on Linux and Darwin (and also to some extent FreeBSD, Windows, …) | 02:45:59 |
emily | so system header portability is still a concern (and has broken the build in the past) | 02:46:26 |
fzakaria | aren't those controlled by IFDEF macros so it's still IWYU..
anyways I don't think 100% is necessary | 02:54:29 |
fzakaria | but something more than today; I open any file and 1/2 of every include is either unused as per clangd or there's no include so it's difficult to follow the hierarchy | 02:54:53 |