| 14 Jul 2025 |
|  fau joined the room. | 23:54:11 |
| 15 Jul 2025 |
 fzakaria | I have a couple of open PRs on nix -- wondering if i can solicit feedback on.
I don't know if i can make Wednesday's meeting. | 20:07:24 |
 Sergei Zimmerman (xokdvium) | The git fetcher ones? I will bring those up, but sadly I'm really not familiar with the fetchers to meaningfully review that. I've at least rebased the https://github.com/NixOS/nix/pull/13456 to fix CI. | 21:30:04 |
|  0xcafca joined the room. | 23:06:14 |
| 16 Jul 2025 |
| fzakaria | Sergei Zimmerman (xokdvium): can you restart also https://github.com/NixOS/nix/pull/13449 | 15:02:33 |
| fzakaria | that's another simple PR | 15:02:37 |
| fzakaria | I'll try to log in today to the meeting but my kid has a competition; | 15:03:04 |
| fzakaria | * Sergei Zimmerman (xokdvium): can you restart also https://github.com/NixOS/nix/pull/13449 please | 15:03:20 |
| Sergei Zimmerman (xokdvium) | In reply to @fzakaria:one.ems.host
Sergei Zimmerman (xokdvium): can you restart also https://github.com/NixOS/nix/pull/13449 please You can also just rebase + force push if you happen to be at the laptop. If not I’ll do it. | 15:03:37 |
| fzakaria | oh i thought you just reran the failed jobs | 15:03:56 |
| fzakaria | rebased 🙇 | 15:04:27 |
| Sergei Zimmerman (xokdvium) | It’s not that easy, because the CI is stuck at 2.30. | 15:04:31 |
| Sergei Zimmerman (xokdvium) | Oh but it’s using the rolling tag at the old revision, and that’s at .1 | 15:05:05 |
| 17 Jul 2025 |
| fzakaria | Those PRs are now green; was there any discussion of them at today's maintainer meeting. O.o | 03:10:36 |
| fzakaria | Sorry i missed it; my kid does Junior Guards and today was his competition day. | 03:10:51 |
 Mic92 | fzakaria: Sergei Zimmerman (xokdvium) https://github.com/Mic92/nix-1/commits/clang-tidy-bonanza/ | 12:13:09 |
| Mic92 | Probably gonna split this into smaller prs | 12:13:32 |
| Sergei Zimmerman (xokdvium) | Do we want the checks in CI to land after the fixes? Did we actually agree on an appropriate set of checks? | 12:29:31 |
| Mic92 | I think we want them in CI. Takes a while to scan. | 13:21:38 |
| Sergei Zimmerman (xokdvium) | I've tried cooking up yesterday. Nixpkgs also has clang-tidy-sarif to output sarif traces, that can be published to the PR as annotations via the codeql-action/upload-sarif@v1 action. Maybe that would work well with combination with git-clang-tidy? | 13:22:58 |
| Mic92 | So you mean you only want to scan affected files? Good idea | 13:29:35 |
| Mic92 | * So you mean you only want to scan changed files? Good idea | 13:29:42 |
| Mic92 | Than we can enable even more checks. | 13:30:28 |
| Sergei Zimmerman (xokdvium) | Yeah, it should be part of clang-tools-extra alongside clang-tidy, but nixpkgs build doesn't seem to have it for some reason. | 13:30:31 |
| Sergei Zimmerman (xokdvium) | https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py | 13:31:00 |
| fzakaria | Clang-tidy bonanza!? | 17:41:18 |
| fzakaria | sweet -- the IWYU is what i'm really after. | 17:41:28 |
| fzakaria | Makes navigating the codebase way easier. | 17:41:34 |
| fzakaria | i'm going to try and take on another issue from FetchTree tonight and stream again... (I'm picking some easy ones for now) | 17:42:03 |
 Alyssa Ross | IWYU is difficult for portable programs like Nix | 19:28:52 |
