!VRULIdgoKmKPzJZzjj:nixos.org

Nix Hackers

902 Members
For people hacking on the Nix package manager itself193 Servers

Load older messages


SenderMessageTime
10 Nov 2025
@djspacewhale:4d2.org@djspacewhale:4d2.org left the room.19:05:26
@Ericson2314:matrix.orgJohn Ericson lovesegfault: git range-diff 14c70d08071093d81d4d614d0e36bbd1db19cf24^..14c70d08071093d81d4d614d0e36bbd1db19cf24 273f7a08421f763788e4c214cca165868617480f^..273f7a08421f763788e4c214cca165868617480f 19:36:25
@Ericson2314:matrix.orgJohn Ericsonreviewing your stuff19:36:27
@shine:proqqul.netTaeer Bar-Yam

Sergei Zimmerman (xokdvium) I'm trying to move the data into arena, and something appears to be leaking. Any idea why? The assignment operator should clean up the existing value, right?

        attrs = AttrDefs{std::move(attrs), arena};
        if (inheritFromExprs)
            inheritFromExprs = std::make_unique<std::pmr::vector<Expr *>>(std::move(*inheritFromExprs), arena);
        dynamicAttrs = DynamicAttrDefs{std::move(dynamicAttrs), arena};
21:49:47
@shine:proqqul.netTaeer Bar-Yam

std::map move constructor (AttrDefs is std::map):

      /// Allocator-extended move constructor.
      map(map&& __m, const __type_identity_t<allocator_type>& __a)
      noexcept(is_nothrow_copy_constructible<_Compare>::value
	       && _Alloc_traits::_S_always_equal())
      : _M_t(std::move(__m._M_t), _Pair_alloc_type(__a)) { }
22:12:33
11 Nov 2025
@roberthensing:matrix.orgRobert Hensing (roberth)Would be great to have range diffs for force pushes on GitHub https://github.com/NixOS/nix/issues/1454309:30:31
@roberthensing:matrix.orgRobert Hensing (roberth) Mic92: would you be able to set that up? 09:30:54
@joerg:thalheim.ioMic92Maybe in non-critical infra?09:32:32
@roberthensing:matrix.orgRobert Hensing (roberth)I'm not familiar with that, but sounds great09:32:50
@joerg:thalheim.ioMic92We got a server running a bunch of random things in NixOS infra09:33:19
@joerg:thalheim.ioMic92actually two09:33:24
@roberthensing:matrix.orgRobert Hensing (roberth)Seems like an ok place to run this too then09:33:45
@joerg:thalheim.ioMic92where is the source for this?09:34:02
@roberthensing:matrix.orgRobert Hensing (roberth)seems to be https://github.com/rust-lang/triagebot09:34:31
@roberthensing:matrix.orgRobert Hensing (roberth)ah, needs packaging09:35:19
@roberthensing:matrix.orgRobert Hensing (roberth)unless you want to experiment with an unpackaged build09:35:43
@roberthensing:matrix.orgRobert Hensing (roberth)I feel quite confident that this would add value though09:35:54
@mschwaig:matrix.orgMartin Schwaighoferhttps://github.com/mschwaig/nixpkgs/tree/triagebot 😄13:57:49
@joerg:thalheim.ioMic92what else does it do beyond range-diff?15:06:57
@joerg:thalheim.ioMic92For range-diff I am almost inclined to just have a github action. It doesn't sound too code.15:07:39
@roberthensing:matrix.orgRobert Hensing (roberth)Merge conflict notifications also stood out to me15:11:10
@roberthensing:matrix.orgRobert Hensing (roberth)Basically see the menu under Triagebot at https://forge.rust-lang.org/triagebot/index.html15:11:41
@roberthensing:matrix.orgRobert Hensing (roberth) * Mic92: Merge conflict notifications also stood out to me 15:12:00
@joerg:thalheim.ioMic92Okay. I am just a bit about all those extra features: https://github.com/rust-lang/triagebot/blob/4b0a0c5afa90af590d8473ab60cead4a8de0a7bc/src/jobs.rs#L2015:12:37
@joerg:thalheim.ioMic92We don't have zulip15:12:46
@mschwaig:matrix.orgMartin SchwaighoferI packaged it, but I did not try it, which is why I did not open a PR yet.15:21:42
@joerg:thalheim.ioMic92thanks. I would like to have a bit of a closer look, if it doesn't do something weird, we might not want.15:22:31
@shine:proqqul.netTaeer Bar-Yam Sergei Zimmerman (xokdvium) We discussed putting allocBytes() into EvalMemory yesterday. Not sure if you meant locally or to make a PR, but I decided to make a PR: https://github.com/NixOS/nix/pull/14544 16:51:41
@oak:universumi.fioak 🏳️‍🌈♥️ changed their profile picture.19:19:41
@shine:proqqul.netTaeer Bar-YamI'm getting linker errors for undefined asan and ubsan symbols that I wasn't getting a couple days ago19:05:58

Show newer messages


Back to Room ListRoom Version: 6