| 10 Nov 2025 |
| @djspacewhale:4d2.org left the room. | 19:05:26 |
John Ericson | lovesegfault: git range-diff 14c70d08071093d81d4d614d0e36bbd1db19cf24^..14c70d08071093d81d4d614d0e36bbd1db19cf24 273f7a08421f763788e4c214cca165868617480f^..273f7a08421f763788e4c214cca165868617480f | 19:36:25 |
John Ericson | reviewing your stuff | 19:36:27 |
Taeer Bar-Yam | Sergei Zimmerman (xokdvium) I'm trying to move the data into arena, and something appears to be leaking. Any idea why? The assignment operator should clean up the existing value, right?
attrs = AttrDefs{std::move(attrs), arena};
if (inheritFromExprs)
inheritFromExprs = std::make_unique<std::pmr::vector<Expr *>>(std::move(*inheritFromExprs), arena);
dynamicAttrs = DynamicAttrDefs{std::move(dynamicAttrs), arena};
| 21:49:47 |
Taeer Bar-Yam | std::map move constructor (AttrDefs is std::map):
/// Allocator-extended move constructor.
map(map&& __m, const __type_identity_t<allocator_type>& __a)
noexcept(is_nothrow_copy_constructible<_Compare>::value
&& _Alloc_traits::_S_always_equal())
: _M_t(std::move(__m._M_t), _Pair_alloc_type(__a)) { }
| 22:12:33 |
| 11 Nov 2025 |
Robert Hensing (roberth) | Would be great to have range diffs for force pushes on GitHub https://github.com/NixOS/nix/issues/14543 | 09:30:31 |
Robert Hensing (roberth) | Mic92: would you be able to set that up? | 09:30:54 |
Mic92 | Maybe in non-critical infra? | 09:32:32 |
Robert Hensing (roberth) | I'm not familiar with that, but sounds great | 09:32:50 |
Mic92 | We got a server running a bunch of random things in NixOS infra | 09:33:19 |
Mic92 | actually two | 09:33:24 |
Robert Hensing (roberth) | Seems like an ok place to run this too then | 09:33:45 |
Mic92 | where is the source for this? | 09:34:02 |
Robert Hensing (roberth) | seems to be https://github.com/rust-lang/triagebot | 09:34:31 |
Robert Hensing (roberth) | ah, needs packaging | 09:35:19 |
Robert Hensing (roberth) | unless you want to experiment with an unpackaged build | 09:35:43 |
Robert Hensing (roberth) | I feel quite confident that this would add value though | 09:35:54 |
Martin Schwaighofer | https://github.com/mschwaig/nixpkgs/tree/triagebot 😄 | 13:57:49 |
Mic92 | what else does it do beyond range-diff? | 15:06:57 |
Mic92 | For range-diff I am almost inclined to just have a github action. It doesn't sound too code. | 15:07:39 |
Robert Hensing (roberth) | Merge conflict notifications also stood out to me | 15:11:10 |
Robert Hensing (roberth) | Basically see the menu under Triagebot at https://forge.rust-lang.org/triagebot/index.html | 15:11:41 |
Robert Hensing (roberth) | * Mic92: Merge conflict notifications also stood out to me | 15:12:00 |
Mic92 | Okay. I am just a bit about all those extra features: https://github.com/rust-lang/triagebot/blob/4b0a0c5afa90af590d8473ab60cead4a8de0a7bc/src/jobs.rs#L20 | 15:12:37 |
Mic92 | We don't have zulip | 15:12:46 |
Martin Schwaighofer | I packaged it, but I did not try it, which is why I did not open a PR yet. | 15:21:42 |
Mic92 | thanks. I would like to have a bit of a closer look, if it doesn't do something weird, we might not want. | 15:22:31 |
Taeer Bar-Yam | Sergei Zimmerman (xokdvium) We discussed putting allocBytes() into EvalMemory yesterday. Not sure if you meant locally or to make a PR, but I decided to make a PR: https://github.com/NixOS/nix/pull/14544 | 16:51:41 |
| oak 🏳️🌈♥️ changed their profile picture. | 19:19:41 |
Taeer Bar-Yam | I'm getting linker errors for undefined asan and ubsan symbols that I wasn't getting a couple days ago | 19:05:58 |