| 28 Jul 2025 |
 John Ericson | I am not opposed to std::variant<json, string> as a kind of "parse on demand" data structure | 14:14:54 |
| John Ericson | but it would be good to know whether there is actual a perf issue or not | 14:15:13 |
| John Ericson | I would think that when .drv is read, it is usually also built, so the parsing will happen anyways, eventually | 14:15:37 |
| John Ericson | likewise when drv is created in the evaluator, we'll have a json object, and end to serializing it, either way | 14:15:58 |
 Sergei Zimmerman (xokdvium) | Microbenchmarks with google/benchmark? | 14:16:08 |
| John Ericson | well my argument above is microbenchmarks would kinda miss the point | 14:16:42 |
| John Ericson | yes, parsing does become more expensive | 14:16:48 |
| John Ericson | but other things become less expensive | 14:16:53 |
| John Ericson | and it should be some O(drvs) thing either way | 14:17:06 |
| Sergei Zimmerman (xokdvium) | In reply to @Ericson2314:matrix.org
well my argument above is microbenchmarks would kinda miss the point But that change would affect store derivation instantiations, right? Or is that not the case? | 15:54:37 |
| John Ericson | what do you mean by instantiations? | 16:05:59 |
| John Ericson | creating them in the evaluator? | 16:06:05 |
| 29 Jul 2025 |
 Mic92 | John Ericson: Sergei Zimmerman (xokdvium) https://github.com/NixOS/nix/pull/13569 | 07:42:09 |
| Mic92 | Microbenchmarks for derivation parsing | 07:42:58 |
| John Ericson | thanks Mic92! | 14:58:04 |
| 31 Jul 2025 |
|  Sammy (It/Its) left the room. | 10:11:40 |
| 29 Jul 2025 |
| John Ericson | https://github.com/NixOS/nix/issues/13570 issue I am curious about | 14:58:08 |
| Mic92 | Left a comment. | 15:17:42 |
| John Ericson | thanks! | 15:24:40 |
| John Ericson | didn't think of that angle | 15:24:43 |
| John Ericson | Mic92: any idea where we would get a nice meaty real-world structured attrs derivation? | 20:17:00 |
| John Ericson | I'll need that to test my PR | 20:17:26 |
| John Ericson | nevermind | 20:35:30 |
| John Ericson | firefox.overrideAttrs (_: { __structuredAttrs = true; }) that works | 20:35:44 |
| John Ericson | oh nevermind i grepped wrong, it was already structured attrs! | 20:38:06 |
| John Ericson | Mic92 Sergei Zimmerman (xokdvium) OK yeah firefox parses 4 times slower | 20:39:21 |
| Sergei Zimmerman (xokdvium) | In reply to @Ericson2314:matrix.org
Mic92 Sergei Zimmerman (xokdvium) OK yeah firefox parses 4 times slower So doing the lazy thing is worth it certainly. | 20:40:10 |
| John Ericson | OK! | 20:40:17 |
| John Ericson | Sergei Zimmerman (xokdvium): I wonder if I should use mutable since it is morally pure | 20:41:03 |
| John Ericson | not good for concurrency const | 20:41:13 |
