Nix Hackers | 883 Members | |
| For people hacking on the Nix package manager itself | 189 Servers |
| Sender | Message | Time |
|---|---|---|
| 18 Jul 2025 | ||
| sure; still better than current model. You can special case the 10% rather than give up on the 90% | 15:08:38 | |
In reply to @fzakaria:one.ems.hostYou mean the clang-tidy one? Works quite well on nix-eval-jobs | 17:33:14 | |
In reply to @qyliss:fairydust.spaceMaybe that can be enabled somehow for nix header only? | 17:34:34 | |
| Same actually for platform specific header - could be a bit tedious though | 17:35:25 | |
| @xokdvium:matrix.org: clang format stuff is good to go? | 17:36:58 | |
| I think so. The diff is good and the auto-rebase script seems to work well. | 17:37:33 | |
| Okay. Hit it! | 17:38:04 | |
| Done! No more range formatting. Yay! | 17:40:50 | |
| Pinned an issue about the auto-rebase script: https://github.com/NixOS/nix/issues/13502 | 18:02:18 | |
| I know that one of the expensive parts of CI with Nix monorepos is evaluation on each commit in part because there's no re-use of evaluation caches across commits. I see that a new AttrDb is created for each fingerprint (https://github.com/NixOS/nix/blob/b8d223a2106c7dbdb0c61f822288195ee9e26e9b/src/libexpr/eval-cache.cc#L75). For those with knowledge about evaluation caching as it is currently implemented: would it be feasible to rewrite it such that entries in Attributes use the hash of their source files as part of their primary key? As an example, if the hashes of the files read to evaluate an attribute doesn't change across two commits, the result from the first evaluation would be returned for the second (it would be cached). | 22:05:10 | |
| 22:09:06 | ||
| 22:13:42 | ||
| 19 Jul 2025 | ||
In reply to @connorbaker:matrix.orgI think part of the problem is that you can't really say which files are the sourcefiles of an attribute without an evaluation, right? | 17:41:11 | |
| 20 Jul 2025 | ||
I think you could if using the flake interface. I've lookged through the eval-cache.cc file a bit, here's an idea.Consider the portion which involves getting the keys of an attribute set. If before and after forcing a value you were snapshot and then compare the results of the import cache, that could be a start. | 03:48:39 | |
I plan to work on that starting Sep/Oct. Might work regardless of flakes :: Bool | 15:16:39 | |
In reply to @ma27:nicht-so.sexyEvaluation should form a tree of visited files theoretically. So you could go and rehash all the files and once you find the first divergence you need to reeval (if we could take incremental snapshots of the evaluator state and flatten the visited files into a list on the time axis, you could even pick up the eval maybe from where it left off? Essentially if you change only a leaf file, you only reimport the leaf) | 15:31:04 | |
| It's about time the compile times got better. Yeeted https://github.com/NixOS/nix/pull/13510 and https://github.com/NixOS/nix/pull/13512. | 19:25:10 | |
| This smells much like Boost.Spirit or Boost.X3 | 20:41:54 | |
| 21 Jul 2025 | ||
| If youโre going to NixCamp or NixCon this year, Iโd love to find out more about your thoughts on how that could be implemented! | 02:34:48 | |
| I'll be at NixCon. Basic idea is: refactor evaluation so that it's an interaction between these three actors and "communication links": CLI - Evaluator - OS, and nothing else. Then MITM the Evaluator on both sides by recording the interactions of previous calls to the evaluator, and replaying them if possible. | 09:05:43 | |
| It's somewhat of a research project; nothing is guaranteed | 09:07:02 | |
| Thats kinda what i was proposing https://matrix.to/#/!VRULIdgoKmKPzJZzjj:nixos.org/$FvXA39aRGz0iER7ZM-bRtUkJCuorYa0Ecy_YupgUPC8?via=nixos.org&via=matrix.org&via=nixos.dev ill be at nixcon too. Definitely will be around for this | 09:08:24 | |
| 11:04:23 | ||
| Iโd love to talk more about this with you all! Any chance C++ has something akin to Haskellโs STM? | 14:11:52 | |
| tomberek you might be interested in this โ I know I talked with you about having an import cache which stores the processed AST instead of the file itself. (One idea I had was to key on the hash of the AST so formatting wouldnโt cause cache misses.) | 14:44:35 | |
| .oO(Unison...) | 14:45:29 | |
| see https://matrix.to/#/!VRULIdgoKmKPzJZzjj:nixos.org/$ynuYm1cT2gUMemb4CiyueY7KlkO0yqppb8i9xb6ENJ8?via=nixos.org&via=matrix.org&via=nixos.dev for my attempts | 14:48:07 | |
unfortunately to trace builtins.readFile you need scopedImport which slows things down a bunch | 14:48:23 | |
In reply to @emilazy:matrix.orgWell, it would have to be done at the c++ level and the evaluator would have to become serializable for my idea to work | 14:54:00 | |
| yes, that would be better | 14:54:20 | |