| 18 Mar 2025 |
 John Ericson | Robert Hensing (roberth): have any opinions on that? | 18:18:01 |
 Las | In reply to @Ericson2314:matrix.org
Las: I feel like we should merge my commits prior to my last one splitting the files, and then do your commits From your PR or the restricted store one or? | 18:19:00 |
| John Ericson | Las: from the big one (though yes that includes restricted store) | 18:19:17 |
| Las | My PR has the benefit of being simple, but it’s also simpler to rebase possibly | 18:19:39 |
| Las | Maybe smaller PR then with your changes? Which would include what! | 18:19:57 |
| Las | * | 18:22:20 |
| John Ericson | Las: basically I am thinking my PR isn't churn tooo bad until the last commit | 18:30:58 |
| John Ericson | and I want to understand what state moves back and forth with my split classes | 18:31:20 |
| John Ericson | when you move the stuff to lambdas | 18:31:25 |
| Las | In reply to @Ericson2314:matrix.org
Las: basically I am thinking my PR isn't churn tooo bad until the last commit I’m honestly not sure I’m a fan of the prepareBuild thing. It seems like a change that moves from a local optimum to a worse directionally momentarily and then leaves it there. | 18:33:51 |
| Las | Is it really that much more work to just take it out of the class and return of struct of what it does? | 18:34:10 |
| John Ericson | it's not that I think anything is wrong with your PR, it is just the modularity is supposed to make it easier to understand these changes | 18:34:26 |
| John Ericson | the prepare/unprepare is supposed to be temporary | 18:35:06 |
| John Ericson | it is just to separate that stuff from the goal code | 18:35:15 |
| John Ericson | the remaining tryLocalBuild is very scheduling oriented | 18:35:32 |
| John Ericson | Robert Hensing (roberth): is with you at oceansprint? | 18:36:16 |
| John Ericson | I am kinda hoping we can do extra video meetings this week :) | 18:36:25 |
| John Ericson | if it doesn't cramp the fun around there | 18:36:33 |
| John Ericson | I would love to have everything merged by friday! | 18:36:40 |
| Las | In reply to @Ericson2314:matrix.org
the prepare/unprepare is supposed to be temporary But without the latter commits it makes less sense | 18:38:46 |
| Las | In reply to @Ericson2314:matrix.org
Robert Hensing (roberth): is with you at oceansprint? Yep | 18:38:52 |
| John Ericson | I am saying still do the class split | 18:39:09 |
| John Ericson | just not the file split | 18:39:11 |
| John Ericson | because then we'd just get worse git conflicts when you move things from LocalDerivationGoal to (closures inside) DerivationBuilder | 18:39:47 |
| John Ericson | I am happy to redo the file split after your stuff is landed | 18:40:00 |
| John Ericson | Also I am unsure whether the cleanup change is correct | 18:40:18 |
| John Ericson | because exceptions and things can cause the destructure to run in other cases | 18:40:28 |
| Las | If you include that then I think 12668 first is easier because it’s more mechanical. | 18:41:08 |
| Las | In reply to @Ericson2314:matrix.org
Also I am unsure whether the cleanup change is correct I don’t think it was ever used | 18:41:31 |
| Las | Was it? | 18:41:37 |
