| 29 Aug 2025 |
fzakaria | (it parses it wrong... but it succeeds the parse) | 23:53:07 |
fzakaria | i.e. github.com:/owner/repo.git | 23:53:13 |
fzakaria | (probably another boost bug to open) | 23:53:18 |
fzakaria | k i added those guards back and pushed. | 23:55:38 |
fzakaria | if (auto r = boost::urls::parse_uri(url); r && r->has_scheme() && r->has_authority()) {
return parseURL(url);
}
if (hasPrefix(url, "file:"))
return parseURL(url);
| 23:55:45 |
| 30 Aug 2025 |
John Ericson | we should not use two UIR parsers | 00:01:46 |
John Ericson | if we need to check schem and authority | 00:01:55 |
John Ericson | we can do it on our parseURL | 00:01:59 |
fzakaria | gonna make dinner; put a comment on the PR | 00:02:50 |
fzakaria | and i'll follow up on it | 00:02:52 |
fzakaria | 👍️ | 00:02:56 |
fzakaria | * gonna make dinner; put a comment on the PR please | 00:03:02 |
fzakaria | I think boost and parseURL are too lenient though and scp style are making it through | 00:04:57 |