| 22 Oct 2025 |
| 0xcafca changed their profile picture. | 10:23:31 |
tomberek | @niksnut:matrix.org: builtins.fetchTree cannot take advantage of the "__final" optimization. This means usages of flake-compat will re-fetch inputs unnecessarily. Is there a way to expose `prim_fetchFinalTree`. This can create a large performance regression. | 15:11:06 |
niksnut | I think we should allow fetchTree { final = true; ... } | 15:11:43 |
Robert Hensing (roberth) | I get what it does but I never felt like I had a complete understanding somehow. If we were wrong about final we could always design something better without the pressure and call it fetchSource :) | 15:14:03 |
niksnut | final just means it won't add more attributes | 15:17:39 |
tomberek | @roberthensing:matrix.org: is the concern that it would be abused ir ossify some behavior? | 15:26:18 |
Robert Hensing (roberth) | I guess I just expected it to be prettier | 15:26:44 |
Robert Hensing (roberth) | sometimes things just aren't, and that's ok | 15:27:35 |
tomberek | I suspect this can get better with lazy paths/trees, but that seems to be further in the future. | 15:28:00 |
Robert Hensing (roberth) | the basic question seems to be: do we want to trust the lock file, and I think usually the answer is yes, final = true; | 15:29:24 |
Robert Hensing (roberth) | if you can't trust your lock file, you're either editing it by hand, which you shouldn't do, or letting people you don't trust update, which you know, you'd have bigger problems | 15:29:52 |
Robert Hensing (roberth) | I feel like true should probably be the default in a future version of this primop if we have one | 15:30:55 |
Robert Hensing (roberth) | anyway, making final part of the public interface seems fine to me | 15:31:52 |