| 28 Oct 2025 |
Mic92 | Oh, why is auto-review enabled again :) | 20:38:50 |
lassulus | maybe because we inherited the default settings? | 20:39:21 |
lassulus | disable both? | 20:39:24 |
lassulus | or only the first? | 20:39:27 |
Mic92 | I think we don't need auto reviews. second one can stay. also no " Enable GitHub Checks" | 20:39:49 |
lassulus | ok, done | 20:40:35 |
Mic92 | I'll test again | 20:40:55 |
lassulus | maybe we need similar settings for nix-community :) | 20:40:58 |
Mic92 | I have the feeling that our setting in the webui get overriden by the yaml file now.
Sergei Zimmerman (xokdvium) https://github.com/NixOS/nix/pull/14402 <- tried to add that.
| 20:44:42 |
Mic92 | ah hang on. | 20:45:10 |
Mic92 | schema might be not correct | 20:45:14 |
Mic92 | Otherwise I am also ok, with just having this on my PRs or people that don't mind. | 20:50:28 |
Mic92 | Okay. Looks like the message is gone now: https://github.com/NixOS/nix/pull/14403 | 20:50:41 |
Taeer Bar-Yam | Thanks, yeah. I really appreciate the consideration. We can have a longer conversation about it if you want at some point, but the short version is the further I can be away from this stuff the more comfortable I am. | 20:53:19 |
lovesegfault | Mic92: Does it just take a while? https://github.com/NixOS/nix/pull/14392#issuecomment-3458434057 | 20:55:45 |
Mic92 | so it did | 20:56:58 |
Sergei Zimmerman (xokdvium) | Sorry about this. From my understanding this was only supposed to be a somewhat of a tool in the box for maintainers as a last resort to hopefully catch more bugs before they get merged. This won't be force-fed to anybody -- that's for certain. I won't be using this for example. I've yeeted all the comments from all PRs that I could find. | 20:56:58 |
lovesegfault | ah, nice, it worked! | 20:57:10 |
lovesegfault | wow, it's pretty good! | 20:58:05 |
Mic92 | Do we want the high-level summary or not? I probably turn of the poem, because people don't like poems from the looks of it. | 20:58:40 |
Sergei Zimmerman (xokdvium) | I think only review comments are relevant. Everything else is just annoying | 20:59:22 |
Robert Hensing (roberth) | AI poems are antithetical to all that is good in the world | 20:59:27 |
lovesegfault | yes, even for me there are limits | 21:01:56 |
Mic92 | Sergei Zimmerman (xokdvium): this should now all be disabled: https://github.com/NixOS/nix/pull/14404 | 21:05:46 |
Mic92 | Ah, but potentially I should also disable graphs? | 21:06:34 |
Sergei Zimmerman (xokdvium) | Yeah diagrams are also pointless I think | 21:07:58 |
Mic92 | All disabled now. | 21:09:51 |
lovesegfault | Mic92: when I force-push, do I have to comment again or once it's on it keeps reviewing? | 21:33:45 |
Mic92 | lovesegfault: with auto-reviews it was doing it on its own. Might be not the case anymore? | 21:34:14 |
lovesegfault | let's find out, i'll push in a moment | 21:34:32 |