!VRULIdgoKmKPzJZzjj:nixos.org

Nix Hackers

889 Members
For people hacking on the Nix package manager itself190 Servers

Load older messages


SenderMessageTime
28 Oct 2025
@joerg:thalheim.ioMic92Oh, why is auto-review enabled again :)20:38:50
@lassulus:lassul.uslassulusmaybe because we inherited the default settings?20:39:21
@lassulus:lassul.uslassulusdisable both?20:39:24
@lassulus:lassul.uslassulusor only the first?20:39:27
@joerg:thalheim.ioMic92I think we don't need auto reviews. second one can stay. also no " Enable GitHub Checks"20:39:49
@lassulus:lassul.uslassulusok, done20:40:35
@joerg:thalheim.ioMic92I'll test again20:40:55
@lassulus:lassul.uslassulusmaybe we need similar settings for nix-community :)20:40:58
@joerg:thalheim.ioMic92

I have the feeling that our setting in the webui get overriden by the yaml file now.

Sergei Zimmerman (xokdvium) https://github.com/NixOS/nix/pull/14402 <- tried to add that.

20:44:42
@joerg:thalheim.ioMic92ah hang on.20:45:10
@joerg:thalheim.ioMic92schema might be not correct20:45:14
@joerg:thalheim.ioMic92Otherwise I am also ok, with just having this on my PRs or people that don't mind.20:50:28
@joerg:thalheim.ioMic92Okay. Looks like the message is gone now: https://github.com/NixOS/nix/pull/1440320:50:41
@shine:proqqul.netTaeer Bar-YamThanks, yeah. I really appreciate the consideration. We can have a longer conversation about it if you want at some point, but the short version is the further I can be away from this stuff the more comfortable I am.20:53:19
@lovesegfault:matrix.orglovesegfault Mic92: Does it just take a while? https://github.com/NixOS/nix/pull/14392#issuecomment-3458434057 20:55:45
@joerg:thalheim.ioMic92so it did20:56:58
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)Sorry about this. From my understanding this was only supposed to be a somewhat of a tool in the box for maintainers as a last resort to hopefully catch more bugs before they get merged. This won't be force-fed to anybody -- that's for certain. I won't be using this for example. I've yeeted all the comments from all PRs that I could find.20:56:58
@lovesegfault:matrix.orglovesegfaultah, nice, it worked!20:57:10
@lovesegfault:matrix.orglovesegfaultwow, it's pretty good!20:58:05
@joerg:thalheim.ioMic92Do we want the high-level summary or not? I probably turn of the poem, because people don't like poems from the looks of it.20:58:40
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)I think only review comments are relevant. Everything else is just annoying20:59:22
@roberthensing:matrix.orgRobert Hensing (roberth)AI poems are antithetical to all that is good in the world20:59:27
@lovesegfault:matrix.orglovesegfaultyes, even for me there are limits21:01:56
@joerg:thalheim.ioMic92 Sergei Zimmerman (xokdvium): this should now all be disabled: https://github.com/NixOS/nix/pull/14404 21:05:46
@joerg:thalheim.ioMic92Ah, but potentially I should also disable graphs?21:06:34
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)Yeah diagrams are also pointless I think21:07:58
@joerg:thalheim.ioMic92All disabled now.21:09:51
@lovesegfault:matrix.orglovesegfault Mic92: when I force-push, do I have to comment again or once it's on it keeps reviewing? 21:33:45
@joerg:thalheim.ioMic92 lovesegfault: with auto-reviews it was doing it on its own. Might be not the case anymore? 21:34:14
@lovesegfault:matrix.orglovesegfaultlet's find out, i'll push in a moment21:34:32

Show newer messages


Back to Room ListRoom Version: 6