!VRULIdgoKmKPzJZzjj:nixos.org

Nix Package Manager development

862 Members
For people hacking on Nix: https://github.com/NixOS/nix Nix maintainers can be reached here.185 Servers

Load older messages


SenderMessageTime
21 Oct 2025
@niksnut:matrix.orgEelcoso it has to touch at least 1 byte every 4096 bytes21:07:52
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)Yeah that was the overhead. A loop over all the pages21:08:28
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)
   1.23 │       lea    -0x10000(%rsp),%r11
   0.23 │ 15:   sub    $0x1000,%rsp
   1.01 │       orq    $0x0,(%rsp)
  59.12 │       cmp    %r11,%rsp
   0.27 │     ↑ jne    15
21:08:42
@niksnut:matrix.orgEelcoright, that's to avoid a segfault if you have guard pages enabled (which I think is the default)21:09:13
@niksnut:matrix.orgEelcoI would expect the overhead for that loop to be pretty trivial though21:09:31
@niksnut:matrix.orgEelcoin the case where the pages are present21:09:52
22 Oct 2025
@0xcafca:matrix.org0xcafca changed their profile picture.10:21:53
@0xcafca:matrix.org0xcafca changed their profile picture.10:23:31
@tomberek:matrix.orgtomberek @niksnut:matrix.org: builtins.fetchTree cannot take advantage of the "__final" optimization. This means usages of flake-compat will re-fetch inputs unnecessarily. Is there a way to expose `prim_fetchFinalTree`. This can create a large performance regression. 15:11:06
@niksnut:matrix.orgEelco I think we should allow fetchTree { final = true; ... } 15:11:43
@roberthensing:matrix.orgRobert Hensing (roberth) I get what it does but I never felt like I had a complete understanding somehow. If we were wrong about final we could always design something better without the pressure and call it fetchSource :) 15:14:03
@niksnut:matrix.orgEelco final just means it won't add more attributes 15:17:39
@tomberek:matrix.orgtomberek @roberthensing:matrix.org: is the concern that it would be abused ir ossify some behavior? 15:26:18
@roberthensing:matrix.orgRobert Hensing (roberth)I guess I just expected it to be prettier15:26:44
@roberthensing:matrix.orgRobert Hensing (roberth)sometimes things just aren't, and that's ok15:27:35
@tomberek:matrix.orgtomberekI suspect this can get better with lazy paths/trees, but that seems to be further in the future.15:28:00
@roberthensing:matrix.orgRobert Hensing (roberth) the basic question seems to be: do we want to trust the lock file, and I think usually the answer is yes, final = true; 15:29:24
@roberthensing:matrix.orgRobert Hensing (roberth)if you can't trust your lock file, you're either editing it by hand, which you shouldn't do, or letting people you don't trust update, which you know, you'd have bigger problems15:29:52
@roberthensing:matrix.orgRobert Hensing (roberth) I feel like true should probably be the default in a future version of this primop if we have one 15:30:55
@roberthensing:matrix.orgRobert Hensing (roberth) anyway, making final part of the public interface seems fine to me 15:31:52
@roberthensing:matrix.orgRobert Hensing (roberth)iirc a lazier fetchTree would be a mitigation for the performance loss but not a complete fix15:32:17
@tomberek:matrix.orgtomberekWould it make sense for the final to be default if fetchTree has been given enough attributes? (If provided with all the info.)15:43:55
23 Oct 2025
@lovesegfault:matrix.orglovesegfault

First batch of small PRs to enable multipart uploads:

cc. John Ericson Sergei Zimmerman (xokdvium)

02:29:28
@lovesegfault:matrix.orglovesegfaultThese are all tiny so it should be easy to review and merge. If you want to see the big picture, look at https://github.com/NixOS/nix/pull/1433002:30:43
@fzakaria:one.ems.hostfzakariaI finished the Kaitai spec04:21:54
@fzakaria:one.ems.hostfzakariahttps://github.com/fzakaria/nix-nar-kaitai-spec04:21:55
@fzakaria:one.ems.hostfzakariait has test suite also04:21:59
@lovesegfault:matrix.orglovesegfault y'all why is Headers not a map 06:28:04
@lovesegfault:matrix.orglovesegfaultseems strange to use a vec of pair and force me to scan 06:28:21
@joerg:thalheim.ioMic92I did some more work over the last weekend on the installer: https://github.com/NixOS/experimental-nix-installer/pull/51 i hopefully get ci green again this weekend and than i can do some more tests. 09:56:46

Show newer messages


Back to Room ListRoom Version: 6